Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix misdocumented component token meta #43994

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

wving5
Copy link
Contributor

@wving5 wving5 commented Aug 3, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #43987

💡 Background and solution

fix misdocumented component token meta

📝 Changelog

Language Changelog
🇺🇸 English fix misdocumented component token meta in <Drawer /><Anchor />
🇨🇳 Chinese 修正<Drawer /><Anchor /> 部分 token 的错误元信息

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 12d43e1

Swapped the order of comments and properties for some padding variables in components/anchor/style/index.ts and components/drawer/style/index.ts. This change improved the code readability and consistency across the anchor and drawer components.

🔍 Walkthrough

🤖 Generated by Copilot at 12d43e1

  • Swap the order of comments and properties for vertical and horizontal padding in the ComponentToken interface for the anchor and drawer components (link, link). This improves the readability and consistency of the code in components/anchor/style/index.ts and components/drawer/style/index.ts.

@stackblitz
Copy link

stackblitz bot commented Aug 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

@argos-ci
Copy link

argos-ci bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Aug 3, 2023, 7:56 AM

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3fa4f76) 100.00% compared to head (a661af8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43994   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11169     11169           
  Branches      3024      3024           
=========================================
  Hits         11169     11169           
Files Changed Coverage Δ
components/anchor/style/index.ts 100.00% <ø> (ø)
components/drawer/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit ee61b99 into ant-design:master Aug 3, 2023
@wving5 wving5 deleted the fix_doc branch August 3, 2023 09:07
@zombieJ zombieJ mentioned this pull request Aug 4, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footerPaddingInline incorrectly documented as 'Vertical padding of footer'
2 participants