Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Steps keyboard switch #43644

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix: Steps keyboard switch #43644

merged 1 commit into from
Jul 19, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 19, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #43634

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Steps with clickable can not trigger by keyboard.
🇨🇳 Chinese 修复 Steps 配置可点击时不能通过键盘操作的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5b4ce3b

Improved the keyboard accessibility and alignment of the Steps component. Updated the rc-steps dependency and added a focus outline style to the steps item icon in components/steps/style/index.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at 5b4ce3b

  • Add focus outline style to steps item icon for keyboard accessibility (link, link, link)
  • Import genFocusOutline function from ../../style to generate outline style (link)
  • Define stepItemIconCls variable to store class name of icon element (link)
  • Apply genFocusOutline function to icon element when container element is focused with :focus-visible pseudo-class (link)
  • Update rc-steps dependency to fix icon alignment bug (link)
    • Bump rc-steps version from 6.0.0 to 6.0.1 in package.json (link)

@stackblitz
Copy link

stackblitz bot commented Jul 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 381.72 KB (+18 B 🔺)
./dist/antd-with-locales.min.js 441.33 KB (+16 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jul 19, 2023, 4:08 AM

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (614228a) 100.00% compared to head (5b4ce3b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43644   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          657       657           
  Lines        11064     11064           
  Branches      2999      2999           
=========================================
  Hits         11064     11064           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 04e729d into master Jul 19, 2023
@afc163 afc163 deleted the steps-visible branch July 19, 2023 05:39
@zombieJ zombieJ mentioned this pull request Jul 20, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clickable Steps cannot be used with keyboard
4 participants