fix: uniformly set height and border on inputs #43548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
16 tasks
afc163
reviewed
Jul 14, 2023
components/input/style/index.ts
Outdated
| @@ -139,6 +139,7 @@ export const genBasicInputStyle = (token: InputToken): CSSObject => ({ | |||
| position: 'relative', | |||
| display: 'inline-block', | |||
| width: '100%', | |||
| height: token.controlHeight - 2 * token.lineWidth, | |||
There was a problem hiding this comment.
建议改 InputNumber 成 Input 这种实现方式，因为 Input 用的比较多，之前 InputNumber 也是这样的。
There was a problem hiding this comment.
bbb169
force-pushed
the
fixBaselineDifferSame
branch
from
e0722c8
to
b85f024
Compare
afc163
reviewed
Jul 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #43548 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 648 657 +9
Lines 10957 11064 +107
Branches 2975 2999 +24
==========================================
+ Hits 10957 11064 +107
☔ View full report in Codecov by Sentry. |
bbb169
force-pushed
the
fixBaselineDifferSame
branch
from
b85f024
to
846fb6c
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
看下 argos ci，还有不少问题。 
|
bbb169
force-pushed
the
fixBaselineDifferSame
branch
from
846fb6c
to
3e9f61e
Compare
bbb169
force-pushed
the
fixBaselineDifferSame
branch
from
9e0b348
to
8fdbd94
Compare
afc163
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #43528
💡 Background and solution
uniformly set height and border on inputs
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e0722c8
This pull request enhances the style and consistency of the
InputNumberandInputcomponents. It removes the redundant border from theInputNumberwrapper and adjusts the height calculation of theInputcomponent.🔍 Walkthrough
🤖 Generated by Copilot at e0722c8