-
-
Notifications
You must be signed in to change notification settings - Fork 50.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transfer error when reset data in some cases #42785
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42785 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 648 646 -2
Lines 10957 10935 -22
Branches 2976 2970 -6
=========================================
- Hits 10957 10935 -22
☔ View full report in Codecov by Sentry. |
感觉这个实现不太好,太多的 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at fe08ed8
Fixed a bug in the
transfer
component that caused an error when the data source and the target keys were reset. Added a test case to verify the fix and improved the logic of theuseEffect
hook incomponents/transfer/index.tsx
.🔍 Walkthrough
🤖 Generated by Copilot at fe08ed8
DefaultRecordType
andButton
in test filecomponents/transfer/__tests__/index.test.tsx
(link)useEffect
hook incomponents/transfer/index.tsx
to handle noprops.selectedKeys
case (link)components/transfer/__tests__/index.test.tsx
to check no error when data source and target keys are reset by a button in the footer (link)