Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Popconfirm loading should finish #41121

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix: Popconfirm loading should finish #41121

merged 2 commits into from
Mar 8, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

ref #40719

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Popconfirm using Promise to close will not exist loading state even when open again.
🇨🇳 Chinese 修复 Popconfirm 使用 Promise 关闭时再次打开仍然是 loading 状态的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 374.19 KB (-2 B 🔽)
./dist/antd-with-locales.min.js 431.12 KB (-3 B 🔽)

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (dcbf0d7) 100.00% compared to head (2938db8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10475     10440   -35     
  Branches      2860      2842   -18     
=========================================
- Hits         10475     10440   -35     
Impacted Files Coverage Δ
components/_util/ActionButton.tsx 100.00% <100.00%> (ø)
components/radio/radio.tsx 100.00% <0.00%> (ø)
components/checkbox/index.ts 100.00% <0.00%> (ø)
components/checkbox/Checkbox.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 87f13b3 into master Mar 8, 2023
@zombieJ zombieJ deleted the fix-loading branch March 8, 2023 09:20
@SilentFlute
Copy link
Contributor

刚使用的时候发现了这个问题, 还说提个issue, 没想到pr都有了, 而且已经merge掉了, 这速度可以啊, 好顶赞

@zombieJ zombieJ mentioned this pull request Mar 13, 2023
16 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* fix: Popconfirm loading should finish

* chore: update bug version
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: Popconfirm loading should finish

* chore: update bug version
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: Popconfirm loading should finish

* chore: update bug version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants