feat: form instance support getFieldInstance #24711

zombieJ · 2020-06-03T10:45:43Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

v3 里内部做 scroll 用，在文档没有透出。 #23659 里看不少人想要，做成正式 API 给用户用好了。

📝 Changelog

Language	Changelog
🇺🇸 English	Form instance support `getFieldInstance`.
🇨🇳 Chinese	Form 实例支持 `getFieldInstance`。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

View rendered components/form/demo/ref-item.md
View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md
View rendered components/progress/demo/segment.md
View rendered components/progress/index.en-US.md
View rendered components/progress/index.zh-CN.md

ant-design-bot · 2020-06-03T10:50:43Z

ant-design-bot · 2020-06-03T10:51:02Z

codesandbox-ci · 2020-06-03T10:52:16Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc15a46:

Sandbox	Source
antd reproduction template	Configuration

codesandbox-ci · 2020-06-03T10:54:47Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a6722c:

Sandbox	Source
antd reproduction template	Configuration

zombieJ · 2020-06-03T12:56:07Z

v3 里内部做 scroll 用，在文档没有透出。 #23659 里看不少人想要，做成正式 API 给用户用好了。

帮忙看看是不是有必要

components/form/demo/ref-item.md

components/form/Form.tsx

lgtm-com · 2020-06-04T03:03:26Z

This pull request introduces 1 alert when merging 01bb3bc into 71f4a2f - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com · 2020-06-04T04:09:01Z

This pull request introduces 1 alert when merging 07081d2 into 71f4a2f - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

codecov · 2020-06-04T05:52:42Z

Codecov Report

Merging #24711 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           feature   #24711   +/-   ##
========================================
  Coverage    99.21%   99.22%           
========================================
  Files          365      369    +4     
  Lines         7299     7327   +28     
  Branches      2033     1995   -38     
========================================
+ Hits          7242     7270   +28     
  Misses          57       57

Impacted Files	Coverage Δ
components/form/FormItemInput.tsx	`94.11% <ø> (ø)`
components/form/util.ts	`100.00% <ø> (ø)`
components/form/Form.tsx	`100.00% <100.00%> (ø)`
components/form/FormItem.tsx	`99.17% <100.00%> (+0.01%)`	⬆️
components/form/context.tsx	`100.00% <100.00%> (ø)`
components/form/hooks/useCacheErrors.ts	`100.00% <100.00%> (ø)`
components/form/hooks/useForm.ts	`100.00% <100.00%> (ø)`
components/form/hooks/useFrameState.ts	`100.00% <100.00%> (ø)`
components/form/hooks/useItemRef.ts	`100.00% <100.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f4a2f...6a6722c. Read the comment docs.

yakkantiraja · 2020-06-15T05:43:17Z

I have taken latest upgrade but this fix not available. When this fix will be available to use ?

* feat: add successColor for Progress (#24655) * feat: add successColor for Progress * feat: update * fix: update test * remove snap * feat: add test case * refactor success * feat: adjust styyle * feat: add DevWarning * feat: Support rowSelection.dirty (#24718) * feat: Support rowSelection.dirty * rename to reserveKeys * preserveKeys will keep record also * to preserveSelectedRowKeys * feat: add ghost prop for collapse (#24734) * feat: add ghost prop for collapse * doc: version of collapse's ghost prop * refactor: make ghost collapse's less code to a nested style * chore: remove redundant codes in ghost collapse's less & doc * doc: add a background wrapper for ghost collapse demo * doc: dark-theme wrapper bg-color for ghost collapse demo * test: update snapshot of ghost collapse * doc: use softer bg-color on ghost collapse demo * doc: remove disabled panel in ghost collapse demo * feat: form instance support getFieldInstance (#24711) * support getFieldInstance * update doc * fix lint * move func * move into hooks * update ref logic * fix lint * rm only * fix docs * feat: dropdown support arrow (#23869) * feat: dropdown support arrow prop close #22758 * test: update snapshot * fix: fix dropdown cls names * test: update snapshot * test: update snapshot * doc: update demo * test: update demo snapshot * demo * fix: snapshot * chore: change the style of ghost collapse & demo modified (#24762) * refactor: reduce content padding in ghost collapse * doc: remove the wrapper outside ghost collapse Designer want the demo differs from other demos * refactor: remove redundant .less code in collapse * feat: cascader dropdown-render prop (#24812) * feat: cascader dropdown-render prop * fix: update Cascader dropdownRender type annotation * fix: set rc-cascader semver from ^ to ~ * docs: fix coding style in cascader/custom-dropdown * feat: 🆕 support Drawer closeIcon (#24842) * feat: 🆕 support Drawer closeIcon close #19283 close #19153 * add test case * update docs * feat: 🆕 Cascader expandIcon (#24865) * feat: cascader expandIcon * fix: snap * refactor: reduce CSS size (#24846) * refactor: reduce button css size * refactor: remove redundant button .less code * feat: add Table onChange an action param (#24697) * Working on tests * created TableAction type * changed TableActions to tuple * removed chinese documentation line * refactor TableActions * fix documentation * Moved action into extra param * minor doc change * feat: add closeIcon customize tag close (#24885) * feat: add closeIcon customize tag close * docs fix * update snap * fix: css name * update snapshot * snapshot * feat: add radio `optionType` api to set radio option type (#24809) * feat: radio component * docs: update md * fix: snap * test components * fix: use optionType * fix name * add warning * fix * feat: expand rate character (#24903) * feat: expand rate character * fix: demo * fix: snap * Update components/rate/index.zh-CN.md Co-authored-by: 偏右 <[email protected]> * fix Co-authored-by: 偏右 <[email protected]> * Refactor demo code box actions (#24887) * refactor: refine the styling of actions part of demo code-box * fix: lint style * refactor: move Result children to end (#24945) * feat: remove content max-width on dot-step (#24907) * feat: add Skeleton-Image (#24805) * feat: add Skeleton-Image * feat: add docs * fix: adjust skeleton * feat: adjust Image Component * feat: rebase * feat: adjust style * fix: lint * feat: remove size * feat: delete md * feat: fix style * ✨ feat: Mentions support autoSize (#24961) close #17746 * chore: replace textarea with rc-textarea (#24966) * feat: update [email protected] support onChange called when pageSize change (#24964) * feat: update [email protected] and add test case to relative component * fix: lint * delete * feat: add test case for pagination * adjust test case * feat: Implement centered prop in Tabs (#24958) * Implement centered in Tabs along with its tests and docs * Fix build error * Add Chinese translations and remove test case Co-authored-by: Ashkan Pourghasem <[email protected]> * feat: Add modal style parameter (#24773) * add some paramters in default.less * Update components/style/themes/default.less Co-authored-by: Amumu <[email protected]> * change parameter in compact.less Co-authored-by: Crystal Gao <[email protected]> Co-authored-by: Amumu <[email protected]> * feat: export Tabs addIcon (#25006) * feat: export Tabs addIcon * update snapshot * feat: showNow on timepicker and datetimepicker (#25032) * feat: update [email protected] and fix icons of month and quarter picker in DatePicker Component (#25035) * feat: update [email protected] * delete * add * feat: expand rate support props (#24993) * docs: 📝 Add Form.Item hidden in doc (#25108) close #25101 * fix: ⌨️ Improve Pagination accessibility issue (#25119) * ⌨️ Improve Pagination a11y by fixing a W3C error react-component/pagination#280 * update snapshot * 🆙 rc-pagination to 2.4.1 * feat: support triggerSubMenuAction for <Menu /> (#25127) * feat(menu): add triggerSubMenuAction for Menu * feat(menu): test cases * chore: Adjust picker logic (#25135) * chore: update rc-picker 1.10.0 (#25174) * feat: table row check strictly (#24931) * feat: add checkStrictly on Table.rowSelection * fix: LGTM warnings * test: table rowSelection.checkStrictly * test: add cov [wip] * refactor: tree.rowSelection.checkStrictly [wip] * test: table.rowSelection.checkStrictly basic case * feat: support rowKey on checkStrictly table * feat: Table checkStrictly support getCheckboxProps * docs: Table checkStrictly * chore: typo * chore: remove useless comment * chore: update snapshot * chore: update snapshot * fix: fire selectAll on selection dropdown menu & changeRows incorrect in selectAll callback * docs: typo * chore * chore * fix: expand buttons of leaf rows in tree data are not hidden * feat: Table warning about rowKey index parameter * perf: only generate keyEntities when not checkStrictly * refactor: remove useless parseCheckedKeys * refactor: get derived selected & half selected keys from selectedRowKeys * chore: remove env condition stmt * chore: revert index usage & code formatting * chore: rerun ci * docs: table tree-data checkstrictly * test: update snapshots * refactor: use useMergedState hook * chore: rerun ci * chore: rerun ci 2 * chore: revert selection select all behavior * refactor: refactor code based on feature * chore: revert table code format * chore: revert table code format * fix: useMemo deps * fix: useMemo deps * fix: useMemo deps * feat: support preserve (#25186) * docs: add responsibly order for Col (#25139) * feat: add type * feat: add responsibly order cols * feat: add docs * feat: add test case * fix test Co-authored-by: 二货机器人 <[email protected]> Co-authored-by: 偏右 <[email protected]> Co-authored-by: zoomdong <[email protected]> Co-authored-by: 07akioni <[email protected]> Co-authored-by: wendellhu <[email protected]> Co-authored-by: xrkffgg <[email protected]> Co-authored-by: Neto Braghetto <[email protected]> Co-authored-by: Kermit Xuan <[email protected]> Co-authored-by: Ashkan Pourghasem <[email protected]> Co-authored-by: Ashkan Pourghasem <[email protected]> Co-authored-by: hicrystal <[email protected]> Co-authored-by: Crystal Gao <[email protected]> Co-authored-by: Amumu <[email protected]> Co-authored-by: Li Ming <[email protected]>

zombieJ added 2 commits June 3, 2020 18:00

support getFieldInstance

49ee987

update doc

bc15a46

pr-triage bot added the PR: unreviewed label Jun 3, 2020

zombieJ requested a review from afc163 June 3, 2020 10:45

zombieJ changed the base branch from master to feature June 3, 2020 10:46

fix lint

bac6a67

afc163 reviewed Jun 3, 2020

View reviewed changes

components/form/demo/ref-item.md Outdated Show resolved Hide resolved

afc163 reviewed Jun 3, 2020

View reviewed changes

components/form/Form.tsx Outdated Show resolved Hide resolved

zombieJ added 2 commits June 4, 2020 10:52

move func

39b4a02

move into hooks

01bb3bc

update ref logic

07081d2

zombieJ added 3 commits June 4, 2020 13:11

fix lint

e8cbeb2

rm only

9d548a2

fix docs

6a6722c

afc163 approved these changes Jun 5, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jun 5, 2020

afc163 merged commit e46d414 into feature Jun 5, 2020

afc163 deleted the form-instance branch June 5, 2020 10:06

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jun 5, 2020

chenshuai2144 mentioned this pull request Jun 29, 2020

docs: add 4.4.0 changelog #25242

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: form instance support getFieldInstance #24711

feat: form instance support getFieldInstance #24711

zombieJ commented Jun 3, 2020 •

edited by markdownify bot

Loading

ant-design-bot commented Jun 3, 2020 •

edited

Loading

ant-design-bot commented Jun 3, 2020 •

edited

Loading

codesandbox-ci bot commented Jun 3, 2020

codesandbox-ci bot commented Jun 3, 2020 •

edited

Loading

zombieJ commented Jun 3, 2020

lgtm-com bot commented Jun 4, 2020

lgtm-com bot commented Jun 4, 2020

codecov bot commented Jun 4, 2020 •

edited

Loading

yakkantiraja commented Jun 15, 2020

feat: form instance support getFieldInstance #24711

feat: form instance support getFieldInstance #24711

Conversation

zombieJ commented Jun 3, 2020 • edited by markdownify bot Loading

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

ant-design-bot commented Jun 3, 2020 • edited Loading

ant-design-bot commented Jun 3, 2020 • edited Loading

codesandbox-ci bot commented Jun 3, 2020

codesandbox-ci bot commented Jun 3, 2020 • edited Loading

zombieJ commented Jun 3, 2020

lgtm-com bot commented Jun 4, 2020

lgtm-com bot commented Jun 4, 2020

codecov bot commented Jun 4, 2020 • edited Loading

Codecov Report

yakkantiraja commented Jun 15, 2020

zombieJ commented Jun 3, 2020 •

edited by markdownify bot

Loading

ant-design-bot commented Jun 3, 2020 •

edited

Loading

ant-design-bot commented Jun 3, 2020 •

edited

Loading

codesandbox-ci bot commented Jun 3, 2020 •

edited

Loading

codecov bot commented Jun 4, 2020 •

edited

Loading