Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type of action and RcFile #16851

Merged
merged 2 commits into from
Jun 2, 2019
Merged

fix: fix type of action and RcFile #16851

merged 2 commits into from
Jun 2, 2019

Conversation

DiamondYuan
Copy link
Contributor

@DiamondYuan DiamondYuan commented May 29, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@DiamondYuan
Copy link
Contributor Author

see #16850

@netlify
Copy link

netlify bot commented May 29, 2019

Deploy preview for ant-design ready!

Built with commit 81da6e9

https://deploy-preview-16851--ant-design.netlify.com

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #16851 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16851      +/-   ##
==========================================
- Coverage      96%   95.96%   -0.05%     
==========================================
  Files         263      263              
  Lines        7329     7329              
  Branches     2035     2046      +11     
==========================================
- Hits         7036     7033       -3     
- Misses        291      294       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81da6e9...c7bc6b7. Read the comment docs.

@DiamondYuan DiamondYuan requested a review from afc163 May 29, 2019 03:23
@DiamondYuan DiamondYuan changed the title fix: UploadFile should extends File [wip] fix: UploadFile should extends File May 29, 2019
@DiamondYuan DiamondYuan changed the title [wip] fix: UploadFile should extends File fix: UploadFile should extends File May 29, 2019
@zombieJ
Copy link
Member

zombieJ commented May 29, 2019

UploadFile 类似 File 但是不是继承关系,通过 fileList or defaultFileList 设置的 file 不一定是真的 File 对象。

@DiamondYuan
Copy link
Contributor Author

UploadFile 类似 File 但是不是继承关系,通过 fileList or defaultFileList 设置的 file 不一定是真的 File 对象。

也就是说有两种类型?一种是 extends file的,在 action 等地方用到。
一种是 UploadFile ,在 render file list的时候用到?

@DiamondYuan
Copy link
Contributor Author

看了一下 action 接受的参数好像不是 UploadFile

@DiamondYuan DiamondYuan changed the title fix: UploadFile should extends File [wip] fix: UploadFile should extends File May 29, 2019
@afc163 afc163 deleted the fix/uploadFile-type-again branch May 29, 2019 05:51
@DiamondYuan DiamondYuan changed the title [wip] fix: UploadFile should extends File fix: UploadFile should extends File May 29, 2019
@DiamondYuan DiamondYuan requested a review from zombieJ May 29, 2019 05:54
@DiamondYuan DiamondYuan reopened this May 29, 2019
@DiamondYuan DiamondYuan changed the title fix: UploadFile should extends File fix: fix type of action and RcFile May 29, 2019
@afc163 afc163 merged commit 18d3dee into master Jun 2, 2019
readonly lastModified: number;
readonly lastModifiedDate: Date;
readonly size: number;
readonly webkitRelativePath: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有webkitRelativePath 是需要加的 重复定义了 像name, type, lastModified, size都是 File 里本身就有的

@pr-triage pr-triage bot removed the PR: merged label Jun 2, 2019
@ikobe-zz ikobe-zz mentioned this pull request Jun 6, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants