Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input.Search style 属性问题 #4540

Closed
jokemmy opened this issue Jan 10, 2017 · 12 comments
Closed

Input.Search style 属性问题 #4540

jokemmy opened this issue Jan 10, 2017 · 12 comments

Comments

@jokemmy
Copy link

jokemmy commented Jan 10, 2017 •
edited
Loading

版本 [email protected]

现在 <Search style={{ width: 200 }} /> 任然占了一整行, 样式加错地方了吧...是 bug 吧
@afc163
Copy link
Member

afc163 commented Jan 10, 2017

fixed in 37541e3

@afc163 afc163 closed this as completed Jan 10, 2017
@jokemmy
Copy link
Author

jokemmy commented Jan 10, 2017 •
edited
Loading

ok了, 我写完没回看, 问题描述少了代码块, 代码没显示出来, 你居然明白了, 厉害了我的哥

@afc163
Copy link
Member

afc163 commented Jan 10, 2017 •
edited
Loading

昨天刚改的，相当有印象~

@jokemmy
Copy link
Author

jokemmy commented Jan 10, 2017

@afc163 #4334 说是样式与 Input 一致, 我有不同意见, 因为 Search 使用场景跟 Input 不完全一样, 见的比较多的经常是跟 Select 结合使用过滤数据, 样式行为应该跟 Select 一致吧

@afc163
Copy link
Member

afc163 commented Jan 10, 2017

Search 其实就是 Input 多个图标，其他都一样。

@jokemmy
Copy link
Author

jokemmy commented Jan 10, 2017 •
edited
Loading

我把 Search 和 Select 放一行, 加个 { marginRight: 8px } 就有点悲剧了, 图标错位

我倒是觉得以前的蛮好用的, 加个宽度就可以搞定, 现在加宽度也一样, 就是加 margin 悲剧了
不过还好自己覆盖一下样式 inline-block 就行了

@afc163 afc163 reopened this Jan 10, 2017
@afc163
Copy link
Member

afc163 commented Jan 10, 2017 •
edited
Loading

添加 marginRight 时确实还有问题，我再看下。

@afc163
Copy link
Member

afc163 commented Jan 10, 2017

这种情况要把 style 加到 wrapper 上。

@jokemmy
Copy link
Author

jokemmy commented Jan 10, 2017

恩确实这样可以搞定

@afc163 afc163 closed this as completed in dc00b9e Jan 10, 2017
@afc163
Copy link
Member

afc163 commented Jan 10, 2017

差不多把二楼的提交都回滚了。。。

@jokemmy
Copy link
Author

jokemmy commented Jan 10, 2017

哈哈, 好吧

@afc163 afc163 mentioned this issue Jan 10, 2017
Closed
@yesmeck yesmeck mentioned this issue May 15, 2017
Closed
@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afc163 @jokemmy