-
-
Notifications
You must be signed in to change notification settings - Fork 50.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout.Header light theme #40394
Labels
Comments
Kamahl19
changed the title
Layout.Header background customisation
Layout.Header theme prop / bg change
Jan 24, 2023
Kamahl19
changed the title
Layout.Header theme prop / bg change
Layout.Header light theme
Jan 24, 2023
You are right here that we need to build this feature, But I observe that if we use a theme prop for the header it will contain white color, here we face more issues it mixes with the second section if it has white color, so if give white color to the header need also heard shadow or border which is identify this is a header section |
Trace in #38975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this feature solve?
Layout.Header
background color is set to darkant-design/components/layout/style/index.ts
Line 220 in d80fa29
theme
prop or any token which could change this.Menu
has atheme
prop. When we render Menu inside Layout.Header we should be able to set both either to light or dark theme so that they work together nicely.Here is a simple demo https://codesandbox.io/s/header-content-footer-antd-5-1-6-forked-c1e3u4?file=/demo.tsx
What does the proposed API look like?
<Layout.Header theme="light | dark" />
The text was updated successfully, but these errors were encountered: