Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout.Header light theme #40394

Closed
Kamahl19 opened this issue Jan 24, 2023 · 3 comments
Closed

Layout.Header light theme #40394

Kamahl19 opened this issue Jan 24, 2023 · 3 comments

Comments

@Kamahl19
Copy link
Contributor

Kamahl19 commented Jan 24, 2023

What problem does this feature solve?

Layout.Header background color is set to dark

colorBgHeader: '#001529',
and there is no theme prop or any token which could change this.

Menu has a theme prop. When we render Menu inside Layout.Header we should be able to set both either to light or dark theme so that they work together nicely.

Here is a simple demo https://codesandbox.io/s/header-content-footer-antd-5-1-6-forked-c1e3u4?file=/demo.tsx

What does the proposed API look like?

<Layout.Header theme="light | dark" />

@Kamahl19 Kamahl19 changed the title Layout.Header background customisation Layout.Header theme prop / bg change Jan 24, 2023
@Kamahl19 Kamahl19 changed the title Layout.Header theme prop / bg change Layout.Header light theme Jan 24, 2023
@NadirBakhsh
Copy link

NadirBakhsh commented Jan 25, 2023

@Kamahl19

You are right here that we need to build this feature, But I observe that if we use a theme prop for the header it will contain white color, here we face more issues it mixes with the second section if it has white color, so if give white color to the header need also heard shadow or border which is identify this is a header section

image

image

@leo220yuyaodog
Copy link

leo220yuyaodog commented Jan 26, 2023

I also meet the problom. In ConfigProvider, I set the defaultAlgorithm, but the Header in layout is dark.

image

@MadCcc
Copy link
Member

MadCcc commented Feb 1, 2023

Trace in #38975

@MadCcc MadCcc closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants