Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect typing for Tooltip trigger prop -- should be ActionType | ActionType[] #22010

Closed
1 task done
devuxer opened this issue Mar 9, 2020 · 1 comment · Fixed by #22043
Closed
1 task done

Incorrect typing for Tooltip trigger prop -- should be ActionType | ActionType[] #22010

devuxer opened this issue Mar 9, 2020 · 1 comment · Fixed by #22043
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@devuxer
Copy link

devuxer commented Mar 9, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

<Tooltip title="prompt text" trigger={["click", "hover"]}>
  <span>
    Tooltip will show on mouse enter (in desktop) or click (in mobile).
  </span>
</Tooltip>

What is expected?

No error for trigger prop

What is actually happening?

This error appears when mousing over the trigger prop:

Type 'string[]' is not assignable to type 'string'.ts(2322)

Environment Info
antd 4.0.2
React 16.8.0
System Windows 10.0.17763 Build 17763
Browser Version 80.0.3987.132 (Official Build) (64-bit)

The problem is in ant-design/components/tooltip/index.tsx:

export interface AbstractTooltipProps {
  // ...
  trigger?: ActionType; // should be ActionType | ActionType[]

The documentation should also be fixed.

The same bug is found in the dependent library rc-tooltip, which I just reported. See react-component/tooltip#209.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Mar 9, 2020
@ant-design-bot
Copy link
Contributor

Hello @devuxer. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @devuxer, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants