principal_nodal_stress(rnum) etc API suggestion

[1990chs]

principal_nodal_stress(rnum) this API can't assign the nodes numbers. It needs update.
I have check the API document and I found some API can't assign nodes numbers or component.
The list is follow.

principal_nodal_stress(rnum)
element_stress(rnum, principal=False, in_element_coord_sys=False, **kwargs)
nodal_acceleration(rnum, in_nodal_coord_sys=False)
nodal_boundary_conditions(rnum)
nodal_input_force(rnum)
nodal_reaction_forces(rnum)
nodal_time_history(solution_type='NSL', in_nodal_coord_sys=False)
nodal_velocity(rnum, in_nodal_coord_sys=False)

class ansys.mapdl.reader.cyclic_reader.CyclicResult(filename)
nodal_displacement(rnum, phase=0, full_rotor=False, as_complex=False)
nodal_elastic_strain(rnum, phase=0, as_complex=False, full_rotor=False)
nodal_plastic_strain(rnum, phase=0, as_complex=False, full_rotor=False)
nodal_solution(rnum, phase=0, full_rotor=False, as_complex=False)
nodal_stress(rnum, phase=0, as_complex=False, full_rotor=False)
nodal_thermal_strain(rnum, phase=0, as_complex=False, full_rotor=False)
nodal_temperature(rnum, full_rotor=False)```

[akaszynski]

Thanks for posting this @1990chs.

We just had a baby, so it might take me longer than I'd like to patch this bug. I should have something by Monday next week.

[1990chs]

Congratulation. It is OK

[1990chs]

I try to edit the rst.py as follow, do I modify is correct?

[akaszynski]

If you fork and then create a PR, I'll be able to review your work and make suggestions.

[1990chs]

What's the PR? I am not a professional programmer.

[akaszynski]

It's ok, I'm not either :)

PR is a pull request. There's tons of examples on forking a repo and making a pull request. Once you figure it out the first time it's not too bad.

[1990chs]

Thinks,yesterday I try to use vs code to push codes to my github .but not successed . Today I use git bash to push and successed. I have ask a pull request about principal_nodal_stress() API

[jgd10]

This appears to have been fixed by #56 ? If so is there anything else needed or can we close the issue?

[jgd10]

Since this appears to be fixed I'll close this for now and we can reopen if something was missed!