Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Input.connect and Inputs.connect #1993

Open
3 tasks done
PProfizi opened this issue Jan 7, 2025 · 0 comments
Open
3 tasks done

Refactor Input.connect and Inputs.connect #1993

PProfizi opened this issue Jan 7, 2025 · 0 comments
Labels
refactoring Code refactoring only

Comments

@PProfizi
Copy link
Contributor

PProfizi commented Jan 7, 2025

Before submitting the issue

  • I have checked for Compatibility issues
  • I have searched among the existing issues
  • I am using a Python virtual environment

Description of the bug

Input.connect and Inputs.connect have a lot of duplicated code, with some fixes in one and not the other. This is a big potential source of bugs at the center of the DPF logic.
Also improve coverage, especially for raised errors.

Steps To Reproduce

See for example #1991

Which Operating System causes the issue?

Windows, MacOS, Linux

Which DPF/Ansys version are you using?

DPF Server 2025.2.pre0

Which Python version causes the issue?

3.13

Installed packages

NA
@PProfizi PProfizi added the refactoring Code refactoring only label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code refactoring only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PProfizi