Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Case where only a prerelease is installed on system #5264

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Alberto-DM
Copy link
Contributor

Solves a bug preventing AEDT from opening when only a pre-release is installed on the system.

Solves #5258

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Oct 8, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch !

@SMoraisAnsys SMoraisAnsys changed the title fixed bug when only a prerelease is installed on system FIX: Case where only a prerelease is installed on system Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (837c472) to head (aba3f00).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5264      +/-   ##
==========================================
- Coverage   83.25%   83.25%   -0.01%     
==========================================
  Files         143      143              
  Lines       58442    58444       +2     
==========================================
  Hits        48655    48655              
- Misses       9787     9789       +2     

@SMoraisAnsys SMoraisAnsys merged commit eff74b2 into main Oct 9, 2024
41 of 42 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/desktop_version_pre-release branch October 9, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants