Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Fix 2025R1 compatibility #5261

Merged
merged 24 commits into from
Oct 8, 2024
Merged

CHORE: Fix 2025R1 compatibility #5261

merged 24 commits into from
Oct 8, 2024

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) October 8, 2024 10:48
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 26 lines in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (2c1c25c) to head (2b19f21).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5261      +/-   ##
==========================================
- Coverage   83.27%   83.25%   -0.03%     
==========================================
  Files         143      143              
  Lines       58442    58442              
==========================================
- Hits        48670    48656      -14     
- Misses       9772     9786      +14     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at 2025R1 required changes.
I left a few comments :)

src/ansys/aedt/core/application/variables.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/desktop.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/hfss3dlayout.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modeler/circuits/object_3d_circuit.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/layer_stackup.py Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys merged commit 837c472 into main Oct 8, 2024
38 of 39 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the chore/fix_2025r1 branch October 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants