Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style check #976

Closed
akaszynski opened this issue Mar 22, 2022 · 0 comments · Fixed by #982
Closed

Fix style check #976

akaszynski opened this issue Mar 22, 2022 · 0 comments · Fixed by #982
Assignees
@MaxJPRey

Comments

@akaszynski
Copy link
Contributor

Style check should use pre-commit rather than separately running black and isort. This ensures that if pre-commit runs locally, it will run identically on the CI. See PyMAPDL implementation at:
https://github.com/pyansys/pymapdl/blob/4822d49d94b8e849a57c25c3f74193fa8032c61a/.github/workflows/ci.yml#L21-L33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxJPRey MaxJPRey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pre-commit config in the style workflow. ansys/pyaedt
2 participants
@akaszynski @MaxJPRey