Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Documentation #330

Open
4 tasks
janvonrickenbach opened this issue Jan 10, 2024 · 1 comment
Open
4 tasks

API Documentation #330

janvonrickenbach opened this issue Jan 10, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@janvonrickenbach
Copy link
Contributor

janvonrickenbach commented Jan 10, 2024

@greschd
Copy link
Member

greschd commented Jan 12, 2024

Thanks @janvonrickenbach, agree with everything mentioned.

Regarding the package structure, we might consider adding one more level, for example:

- material_data
- layup_definition
- solid_model
- inspection (section cut, plots, ply book, ...)

The structure on the Model should then be the same.

EDIT: After discussion, we decided not to add this extra layer since it doesn't really improve discoverability. The groups would be unbalanced, layup_definition being by far the largest.

Additionally, I wonder if the enums.py should be split apart, and each enum moved to where it is used.
EDIT: this part we can do, but it's not critical since the canonical import name is anyway at the root level of the module.

@greschd greschd added this to the Initial beta release milestone Jan 16, 2024
@roosre roosre changed the title Prepare release API Documentation Feb 13, 2024
@janvonrickenbach janvonrickenbach self-assigned this Feb 21, 2024
@janvonrickenbach janvonrickenbach removed their assignment Mar 4, 2024
@greschd greschd removed this from the ACE testing milestone Apr 4, 2024
@greschd greschd added the documentation Improvements or additions to documentation label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants