From dca3001795b245812c33547aa7ba0b7693351665 Mon Sep 17 00:00:00 2001 From: Dominik Gresch Date: Fri, 25 Oct 2024 10:47:37 +0200 Subject: [PATCH] Fix network-limited benchmarks not running (#627) The benchmarks with specific network latency or bandwidth had failed to run since the `grpc_server` fixture was renamed to `acp_instance`, but the fixture which overrides it in the benchmarks was not. --- tests/benchmarks/conftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/benchmarks/conftest.py b/tests/benchmarks/conftest.py index fd7e7da0fb..a1ec388173 100644 --- a/tests/benchmarks/conftest.py +++ b/tests/benchmarks/conftest.py @@ -45,7 +45,7 @@ BENCHMARK_IMAGE_NAME = "pyacp-benchmark-runner" -def pytest_ignore_collect(collection_path, path, config): +def pytest_ignore_collect(collection_path, config): # The benchmarks can only be run on Linux, since the 'tc-netem' tool # used for manipulating network speeds is not available on Docker for # Windows / Mac. @@ -159,5 +159,5 @@ def network_options(request): @pytest.fixture -def grpc_server(_benchmark_servers, network_options): +def acp_instance(_benchmark_servers, network_options): return _benchmark_servers[network_options]