Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export logger #100

Merged
merged 3 commits into from
Sep 6, 2023
Merged

export logger #100

merged 3 commits into from
Sep 6, 2023

Conversation

Gryfenfer97
Copy link
Contributor

Should fix #84

@koubaa is it what you expected ?

Copy link
Collaborator

@koubaa koubaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! yes this is what is needed

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #100 (e6f2fe2) into main (8e2f085) will increase coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   95.20%   95.25%   +0.05%     
==========================================
  Files           3        3              
  Lines         250      253       +3     
==========================================
+ Hits          238      241       +3     
  Misses         12       12              

@Gryfenfer97 Gryfenfer97 merged commit 83e07b8 into main Sep 6, 2023
18 checks passed
@Gryfenfer97 Gryfenfer97 deleted the feat/export-logger branch September 6, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing logging
2 participants