-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add secrets to actions that use the bot #556
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@SMoraisAnsys @germa89 @RobPasMue I applied your suggestions. The reason why I was using the environment variables was because of an article Jay shared with us a long time ago about secure development practices in GitHub actions. I haven't been able to find the article, but I'll share it with you if I find it |
Here is an article that talks about using env variables to prevent script injection vulnerabilities: https://www.stepsecurity.io/blog/github-actions-security-best-practices#prevent-script-injection-vulnerabilities-2 Because of this, I think I should add back the env variable for at least the PR title |
Good find @klmcadams - let's do it only for the github-context related things. |
Or even all of them - as long as it is justified, that's fine by me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the feeling you missed some of them @klmcadams - sorry for going back and forth on all these inputs. At least now it's clear.
Replace bot username and email with secrets and update corresponding examples
THIS IS A BREAKING CHANGE