Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance doc-changelog migration guide #499

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Conversation

klmcadams
Copy link
Contributor

Updated the doc-changelog migration guide to clarify setting up the release notes in the CHANGELOG.md file versus the documentation (changelog.rst). Although a couple of the steps are repeated in the "release notes in your documentation" and "release notes in CHANGELOG.md" sections, I think it's clearer.

Previously, you would have to set up everything for the CHANGELOG.md configuration, and then change most of what you had set up if you want to include it in your documentation instead.

@klmcadams klmcadams requested a review from a team as a code owner June 6, 2024 19:05
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Generic maintenance related label Jun 6, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments. LGTM otherwise!

doc/source/migrations/docs-changelog-setup.rst Outdated Show resolved Hide resolved
doc/source/migrations/docs-changelog-setup.rst Outdated Show resolved Hide resolved
doc/source/migrations/docs-changelog-setup.rst Outdated Show resolved Hide resolved
@klmcadams
Copy link
Contributor Author

@ansys/pyansys-core do you guys prefer having a space between the steps or no space?

Space:
space

No space:
nospace

@RobPasMue
Copy link
Member

@ansys/pyansys-core do you guys prefer having a space between the steps or no space?

Space: space

No space: nospace

This is related to: #499 (comment)

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
I'd go with the no space approach. It doesn't look bad without it and avoids unexpected | in the file.

@klmcadams klmcadams merged commit 854d1cd into main Jun 10, 2024
16 checks passed
@klmcadams klmcadams deleted the maint/update-docs branch June 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants