-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enhance doc-changelog migration guide #499
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments. LGTM otherwise!
This is related to: #499 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
I'd go with the no space approach. It doesn't look bad without it and avoids unexpected |
in the file.
…into maint/update-docs
Updated the doc-changelog migration guide to clarify setting up the release notes in the
CHANGELOG.md
file versus the documentation (changelog.rst
). Although a couple of the steps are repeated in the "release notes in your documentation" and "release notes inCHANGELOG.md
" sections, I think it's clearer.Previously, you would have to set up everything for the
CHANGELOG.md
configuration, and then change most of what you had set up if you want to include it in your documentation instead.