feat: allow upper case in doc-deploy-changelog #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
the
enhancement
RobPasMue
approved these changes
Jun 4, 2024
RobPasMue
changed the title
|
Tested it while enabling the use of upper-case and it seems to work well
Should I also add a type to the commit added when creating the fragment ? We would have by default, "chore: adding changelog entry..." instead of "Adding changelog entry..." |
Revathyvenugopal162
approved these changes
Jun 4, 2024
klmcadams
approved these changes
Jun 4, 2024
MaxJPRey
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Thanks @SMoraisAnsys . I will be able to proceed with my upper case habits regarding PRs' titles.
SMoraisAnsys
commented
Jun 5, 2024
Co-authored-by: Revathy Venugopal <[email protected]>
|
Can we merge this? |
Yes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #496