-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: gh-pages does not exist message for doc-deploy-dev #475
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Can we not just fix this in the |
Agreeing with @RobPasMue, it would be great for new maintainers trying to use ansys actions. |
It would be great if we could check if the input branch exists in the origin. If not, the script creates and pushes it before uploading the content. |
Just wondering if handling non existing branch creation couldn't be performer more simply. Would it be possible to follow the following workflow :
If the branch exists, could a simple |
Hi @SMoraisAnsys, I tried following those steps only but ran into a few issues:
|
Thanks for trying the suggestion and letting me know of the associated limitations ! |
Just a though but it makes sense that it doesn't work without commiting. AFAIK, branch are references to commits. Thus it would be strange to being able to publish an orphan branch without commiting first. Should have though about that before... |
Let's try and get this merged |
@jorgepiloto - please approve whenever you get the chance. I believe your suggestions were addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this improvement !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work, @klmcadams. Merging and patch-releasing this.
Create branch if it doesn't exist in doc-deploy-dev and doc-deploy-stable
Create new gh-pages branch: CI · ansys-internal/pytemplate-sandbox@cc726c4 (github.com)
Update existing gh-pages branch: CI · ansys-internal/pytemplate-sandbox@cc726c4 (github.com)
Create new unique branch: specify branch · ansys-internal/pytemplate-sandbox@eb14ba3 (github.com)
Update existing unique branch: CI · ansys-internal/pytemplate-sandbox@eb14ba3 (github.com)