Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create button enablement when autofilling project name #1706

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

alisonlhart
Copy link
Contributor

Resolves the logic for enabling or disabling the create button.

Adds the placeholder text into the project name field when resetting the form.

(Fixes issues created in #1703).

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: bug, skip-changelog

@alisonlhart alisonlhart removed the bug Something isn't working label Dec 4, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 4, 2024
@alisonlhart alisonlhart removed the bug Something isn't working label Dec 4, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 4, 2024
@alisonlhart alisonlhart removed the bug Something isn't working label Dec 4, 2024
@alisonlhart
Copy link
Contributor Author

Codecov/patch is failing on this PR due to some limitations in the testing framework for our webview apps, which will take time to research and implement tests for. I am overriding the codecov failure to get this bugfix in the new release. We will create more thorough testing for our webviews in a future task.

@alisonlhart alisonlhart merged commit c469ea4 into main Dec 4, 2024
17 of 20 checks passed
@alisonlhart alisonlhart deleted the fix/devfile-project-name branch December 4, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant