Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close editors before running One Click Trial UI test #1551

Conversation

TamiTakamiya
Copy link
Collaborator

We found One Click Trial UI test at Invoke Playbook generation: step in the test runs for #1475 (link to test result). The step was for opening the Playbook Generation UI in the Editor pane and get the text area for input.

  1) VSCode Ansible - UI tests
       Test One Click Trial feature
         Invoke Playbook generation:
     NoSuchElementError: no such element: Unable to locate element: {"method":"xpath","selector":"//vscode-text-area"}
  (Session info: chrome=122.0.6261.156)
      at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:521:15)
      at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:514:13)
      at Executor.execute (node_modules/selenium-webdriver/lib/http.js:446:28)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Driver.execute (node_modules/selenium-webdriver/lib/webdriver.js:742:17)
      at async WebViewBase.findWebElement (node_modules/@redhat-developer/page-objects/out/components/WebviewMixin.js:42:20)
      at async Context.<anonymous> (out/client/test/ui-test/lightspeedOneClickTrialUITest.js:108:30)

I tried several changes and found it could be fixed if all editors are closed after required settings are configured at the beginning of the test case. This PR is for that change on the One Click Trial UI test case.

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I am learning to love this method and its friend webView.switchBack() 🤣

@TamiTakamiya TamiTakamiya merged commit 6922325 into main Sep 26, 2024
18 of 19 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/close-all-editors-before-running-one-click-trial-ui-test branch September 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants