Nesting commands to fix container cleanup #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audgirka
approved these changes
Sep 18, 2024
ganeshrn
approved these changes
Sep 18, 2024
|
I tried testing this change on my own fork, and I'm not seeing the linux UI test failures there: https://github.com/alisonlhart/vscode-ansible/actions/runs/10923846578/job/30322518348?pr=5 |
|
Local tests for macOS and Windows have passed. Manually merging this with the team's approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves a bug where containers were improperly stopped when using the extension in EE mode.
The issue resulted in a
podman cpfailure in the logs, in both upstream and downstream containers. This change adds onto the change in #1535, keepingxargsout of the command for downstream purposes, while still retaining the ability to get the container name for removal.Tests were confirmed to pass with manual local testing.