Skip to content

Commit

Permalink
Nesting commands to fix container cleanup (#1542)
Browse files Browse the repository at this point in the history
* Nesting commands to fix container cleanup

* Adding UI test config change
  • Loading branch information
alisonlhart authored Sep 23, 2024
1 parent e902379 commit 8c4243f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ tasks:
test-ui:
desc: Run UI tests {{.XVFB}}
aliases: [ui]
env:
MOCHA_GREP: Test One Click Trial feature
MOCHA_INVERT: true
cmds:
- yarn webpack-dev
- "{{.VIRTUAL_ENV}}/bin/python3 --version"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,8 @@ export class ExecutionEnvironment {

private cleanUpContainer(containerName: string): void {
const cleanUpCommands = [
`${this._container_engine} stop ${containerName}`,
`${this._container_engine} rm ${containerName}`,
`${this._container_engine} stop $(${this._container_engine} ps -q --filter "name=${containerName}")`,
`${this._container_engine} rm $(${this._container_engine} container ls -aq -f 'name=${containerName}')`,
];

if (!this.doesContainerNameExist(containerName)) {
Expand Down

0 comments on commit 8c4243f

Please sign in to comment.