Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collection] How to display a role documentation ? #1937

Open
nqb opened this issue Jun 25, 2019 · 8 comments
Open

[collection] How to display a role documentation ? #1937

nqb opened this issue Jun 25, 2019 · 8 comments

Comments

@nqb
Copy link
Contributor

nqb commented Jun 25, 2019

Bug Report

SUMMARY

When browsing a collection on Galaxy website, you can't display README.md for a role.

STEPS TO REPRODUCE
EXPECTED RESULTS

You should be able to display README.md for a role like for a standalone role (outside a collection).

ACTUAL RESULTS

Impossible to display README.md for a role.

@nqb nqb changed the title [collection] How to display a role documentation [collection] How to display a role documentation ? Jun 25, 2019
@chouseknecht
Copy link
Contributor

This will be figured out in the next release of Galaxy. We're still sorting out exactly how to document Collections, and what documentation files will be displayed and how by Galaxy.

@geerlingguy
Copy link
Contributor

geerlingguy commented Apr 25, 2020

@ericsysmin
Copy link

ericsysmin commented Apr 26, 2020

I like detailed documentation with tons of examples. I know exactly what I will likely do with the Avi Networks docs directory. Including multiple examples and cross-module and environment docs including more thorough docs than why I could do on Galaxy, or on Ansible docs. It would make plenty of sense to redirect a role docs if desired to readthedocs just like PyPI does. For example when you have over 80 examples of using your modules and you need to handle versioning them.

Would it really make sense to provide playbook documentation that uses 10+ modules within the collection? Yes, I don't think I'd advise that though when documenting a single module docstring.

In galaxy.yml we also have this

# The URL to any online docs
#documentation: http://docs.example.com 

Which could direct to a readthedocs page based on docs/ directory. Which would make sense.

@fabianvf
Copy link

fabianvf commented Jun 8, 2020

The import required me to add role READMEs for the roles in my collection (which is fair), but I was surprised to see that there was apparently no way to view them in the collection UI. Feels a little odd to be required to provide documentation that the users can't even see

@chouseknecht
Copy link
Contributor

We are running the latest galaxy-importer, which actually does transform role README files into HTML. The problem is that we have not updated the API and the frontend Javascript to do anything with the HTML. Collections uploaded to c.rh.c have role README files displayed in the UI, so we have the code. It's a matter of finding the time and hands to implement it here in the community codebase.

@newswangerd
Copy link
Member

For clarity, c.rh.c is cloud.redhat.com.

@geerlingguy
Copy link
Contributor

Mind blown: how did earlier collections like https://galaxy.ansible.com/testing/ansible_testing_content have the ability to display their role READMEs inline when listing all the roles? Screenshot in case this behavior changes:

Screen Shot 2020-06-15 at 8 18 41 PM

@chouseknecht
Copy link
Contributor

I think that's because there was a time when a collection was imported from a GitHub repository rather than an uploaded artifact. Surprised that still exists and actually works. Neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants