Update LDAP user search test #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Blank UI field for user search results in the value [] * Current test to ignore is "if field is None:", which fails since [] is not None * With "if field:", [] is False and properly ignored
bhavenst
added
the
Ready for review
|
Shouldn't we add a test for this as well? |
|
Yeah, was in progress.. Added a case for it now. |
|
Oops, test didn't hit new code.. Standby.. |
bhavenst
force-pushed
the
ldap-search-fix
branch
from
c6572c0 to
dc24f16
Compare
|
OK, unit test added to cover this strange scenario. |
art-tapin
approved these changes
Sep 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDAP auth should require one of User Search or User DN Template, but not both. Currently LDAP auth is blocked if User Search is empty ([]), this change fixes this issue and allows auth when only User DN Template is specified.
This is for: https://issues.redhat.com/browse/AAP-28020
That Jira is now closed, but this is good to fix anyway.