-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis flushdb #617
Merged
Merged
Redis flushdb #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
force-pushed
the
redis_flushdb
branch
from
September 25, 2024 13:44
1f80a45
to
1af0ee7
Compare
john-westcott-iv
force-pushed
the
redis_flushdb
branch
from
September 25, 2024 16:01
1af0ee7
to
1084abd
Compare
john-westcott-iv
force-pushed
the
redis_flushdb
branch
from
September 25, 2024 16:06
1084abd
to
084fa7b
Compare
Quality Gate passedIssues Measures |
bhavenst
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I don't see anything to comment on. Ran all the unit tests as well with no issues locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits in here:
cache.clear()
this eventually does aflushdb
command. The flushdb command will not check the connected users to see if they have access to keys, it just obliterates everything in the Redis DB. This causes issues in a shared Redis installation. This new method is less efficient but will load all of the keys and then attempt to delete them all and just ignores aNoPermissionError
if it tried to delete something it didn't have access to.