Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

VMware Working Group meeting agenda - Sept '17 to Dec 2018 #233

Closed
Akasurde opened this issue Aug 31, 2017 · 72 comments
Closed

VMware Working Group meeting agenda - Sept '17 to Dec 2018 #233

Akasurde opened this issue Aug 31, 2017 · 72 comments
Assignees
@Akasurde @jctanner
Labels
meeting_agenda vmware VMware community

Comments

@Akasurde
Copy link
Member

Akasurde commented Aug 31, 2017 •
edited by dagwieers
Loading

The VMware Working Group focuses on delivering modules and features to Ansible to support working with VMware. The group meets every week on Mondays at 16:00 UTC (see calendar)

More information related to the VMware Working Group is available here

Feel free to add your questions to this ticket to be discussed during the upcoming meeting.

(Migrated from the previous agenda at #206, actionable items are available at VMware: action plan)
@Akasurde
Copy link
Member Author

Akasurde commented Aug 31, 2017 •
edited
Loading

New VMware modules waiting for review/feedback.

Please review these tickets on a weekly basis (if there was new progress, otherwise add instructions to the owner how to continue).

Once merged, please add to CHANGELOG.md !

@pdellaert pdellaert mentioned this issue Aug 31, 2017
Closed
@Akasurde
Copy link
Member Author

Akasurde commented Aug 31, 2017 •
edited
Loading

PR to discuss:

@Akasurde Akasurde added the vmware VMware community label Aug 31, 2017
@Akasurde
Copy link
Member Author

Meeting ended Mon Sep 11 16:56:49 2017 UTC

@Akasurde
Copy link
Member Author

Meeting ended Mon Sep 18 17:15:44 2017 UTC

@Akasurde
Copy link
Member Author

Akasurde commented Oct 2, 2017

Meeting ended Mon Oct 2 17:05:41 2017 UTC.

@dagwieers
Copy link
Contributor

dagwieers commented Oct 4, 2017 •
edited
Loading

I'd like to discuss namespacing VMware modules. Currently almost every VMware-related module is namespaced vca_ or vmware_. We do have vcenter_ and vsphere_ already in use. Whereas, Ansible modules are usually named after the technology/product and the managed object. Most of the modules however manage stuff on vCenter (and only vCenter).

VMware's collection of modules correctly prefixes them vcenter_ and I think we should do this as well. We also have some legacy with vsphere_copy which preferably becomes vcenter_copy.

So my proposal is:

  • Use vcenter_ for vCenter-only modules
  • Keep using vca_ as we already do for VCA-related modules
  • Keep using vmware_ for everything that covers multiple technologies, like vmware_guest for both vCenter and ESXi

(Note sure if we have ESXi-related modules, if so we could introduce esxi_ as a prefix as well.)

The end-goal is to make is more clear what a module relates to, and what parameters relate to as well.

FYI The official way to rename modules, is to deprecate them ('_' prefix), and symlink them in Github. That provides a convenient upgrade path to whatever we decide, as we'll need to fix a few modules anyway.

@dagwieers dagwieers mentioned this issue Oct 4, 2017
Closed
@garbled1
Copy link

garbled1 commented Oct 5, 2017

I'm very interested in helping out in general in the vmware space. I'm using ansible quite heavily to manage hosts in vmware/vcenter, and automate builds, and I've needed to add quite a few features/modules to do so.

However, while looking at the code, I've noticed that there is alot of room for general cleanup, which you have also noted in some of the wiki pages for the vmware group. One thing I would really like to help with, but have no idea how to structure pullups for is the module_utils code.

For example, lets say that 3 modules do a thing, so I want to move it into the module_utils/vmware.py code. Do I submit a single PR with all 4 changes? 1 PR for module utils and then wait until it's pulled to add the rest? What if just 3 modules duplicate code from module_utils? Do I submit 3 separate PR's?

I feel kinda stumped by parts of this. I would love to do that kind of code cleanup/consolidation in the tree, but kind of have no idea how to submit it in a way that isn't difficult for you to process.

@dagwieers
Copy link
Contributor

@garbled1 Probably the best way is to discuss your ideas upfront on channel #ansible-vmware (possibly during the weekly meeting). In most cases you can do all changes in a single PR, as long as the result is that everything still works as before :-) Adding unit or integration tests for the stuff you're modifying (if it doesn't exist yet) is a big plus as it will demonstrate everything still works as before.

@Akasurde
Copy link
Member Author

Akasurde commented Oct 9, 2017 •
edited
Loading

Meeting ended Mon Oct 9 17:04:47 2017 UTC

@jjahns
Copy link

jjahns commented Oct 9, 2017

This happened outside of my window to join. I did talk with the VMW folks on their modules, and there's a lot of things left to do - they did not follow a specific methodology in naming their modules.

@garbled1 garbled1 mentioned this issue Oct 12, 2017
Merged
@jjahns
Copy link

jjahns commented Oct 16, 2017 •
edited
Loading

@dagwieers @garbled1 @Akasurde

We had a discussion in IRC today about naming convention, and VMW team was in on the conversation. There is a consensus that moving forward, all modules that hit either esxi OR vcenter and use the pyvmomi library be prefixed as "vmware_" and any existing modules that use the pyvsphere library be prefixed with "vsphere_". Any additional modules that reflect other products (examples: vcd, vio, vra) be prefixed as "product_".

There is an outstanding item that we need to discuss next week, and that is how these modules will be tested in the future. VMW will discuss internally to determine best course of action, but this needs to be the primary topic of next week.

I have the log of the IRC discussion, but I don't think an official meeting was recorded at https://gist.github.com/jjahns/216fe2662da5fecd6267bd68a3777773. Please ding me appropriately if we didn't follow proper procedure (I was unaware of procedure).

Everyone on the IRC appeared to have consensus, so this should be the way forward.

@kbroughton
Copy link

kbroughton commented Oct 16, 2017 •
edited
Loading

Is there a good space for troubleshooting / sharing running ansibe at vmware?
I'm trying to hook up our alerting system to send and email to jira to auto-create issues.

I created a service account 'svc...' and added it to jira. I can send test emails to svc from my vmware email and it creates a ticket. The following snippet works to send emails to my gmail.com accounts, but it fails without error sending to @vmware.com

   - name: send an email to ops to trigger a jira ticket, assign to cc
  mail:
    host: smtp.mailgun.org
    port: 587
    username: <my username>
    password: "{{ (lookup('credstash', <cred handle>, region='us-west-2') | from_json)['password'] }}"
    to: [email protected]
    from: [email protected]
    cc: [email protected]
    subject: gc is thrashing on {{ inventory_hostname }} for {{ service }}
    body: |
      '{{ service }}  has been restarted - version {{ reg_service_version.stdout }} on {{ inventory_hostname }}'
      {{ alertBody.alert.event.annotations.details }}
      autoremediation generated by ansible/tasks/nurse-gc-is-thrashing.yml
      jenkins job Ops/Nurse/Gc-is-thrashing
      attach: /tmp{{ reg_tempfile.path }}/{{ inventory_hostname }}{{ reg_tempfile.path }}
  delegate_to: localhost

Has anybody set up jira ticket autocreation?

@pdellaert
Copy link

pdellaert commented Oct 28, 2017 •
edited by Akasurde
Loading

Added functionality to vmware_dvs_portgroup PR: ansible/ansible#32298

@Akasurde
Copy link
Member Author

Meeting ended Mon Oct 30 16:35:16 2017 UTC.

@Akasurde Akasurde changed the title VMware Working Group meeting agenda - Sept-Oct 2017 VMware Working Group meeting agenda - Sept-Nov 2017 Nov 6, 2017
@Akasurde
Copy link
Member Author

Akasurde commented Nov 6, 2017

Meeting ended Mon Nov 6 17:05:41 2017 UTC

@Akasurde
Copy link
Member Author

Akasurde commented Nov 16, 2017 •
edited
Loading

vmware_guest is not idempotent if 'folder' is not specified

ansible/ansible#32960

I would like to discuss - what are the adverse effects of this change ?

Result of discussion -
Keep functionality as it is and start with deprecation process.

@Akasurde
Copy link
Member Author

Akasurde commented Nov 20, 2017 •
edited
Loading

PR to discuss - 20 Nov 2017

@Akasurde
Copy link
Member Author

Meeting ended Mon Nov 20 16:58:04 2017 UTC.

@Akasurde
Copy link
Member Author

I would like to discuss -

@Akasurde
Copy link
Member Author

Meeting ended Mon Dec 11 17:08:28 2017 UTC.

@Akasurde
Copy link
Member Author

Meeting ended Mon Dec 18 16:45:19 2017 UTC.

@Akasurde
Copy link
Member Author

Meeting ended Mon Jul 23 16:59:04 2018 UTC

@dagwieers
Copy link
Contributor

dagwieers commented Jul 30, 2018 •
edited
Loading

PR to discuss:

@Akasurde
Copy link
Member Author

@Im0
Copy link

Im0 commented Jul 31, 2018

Did you guys end up agreeing to collaborate on a wiki first? If so, whereabouts? Ta.

@Akasurde
Copy link
Member Author

@Im0 There was no agreement made as such but you can find the wiki here - https://github.com/ansible/community/wiki/VMware. Also, feel free to fill gaps in documentation found at https://docs.ansible.com/ansible/devel/vmware/index.html

@gundalow
Copy link
Contributor

gundalow commented Aug 2, 2018

Ansible Contributor Summit 6 (Part of AnsibleFest 2018 Austin, Texas)

As part of http://www.ansible.com/ansiblefest

  • AnsibleFest Austin will be on both Tuesday 2nd and Wednesday 3rd October 2018
  • The Contributor Summit will also be over two days, on Monday 1st and Thursday 4th October, from 9:30am to 4pm (time subject to change).

This is your event

Ansible succeeds because of its community, and this contributor summit is for you. If you have any topics to discuss, large or small, please be sure to post those topics on the etherpad. For topics that other had added please vote by adding +1

https://etherpad.openstack.org/p/ansible-summit-october-2018

Please see https://groups.google.com/forum/#!topic/ansible-devel/ivrpVbLya8g for further info

Attending in person

We realize that not everybody can attend in person, which is why we’ll again be arranging a video conference and a meeting time on IRC in #ansible-meeting to encourage remote participation. This has worked very well for the past Contributor Summits. We’ll be sending out an email with the information for remote participation about a week before the Contributor Summit.

If you want to attend in-person please sign up at: https://www.eventbrite.com/e/ansible-contributor-conference-austin-2018-tickets-48557063484

After signing up you'll receive an email from Eventbrite with a discount code for AnsibleFest Austin.

Attending remotely

Please add your name at the bottom of this etherpad: https://etherpad.openstack.org/p/ansible-summit-october-2018

Call to action

  1. Add ideas to https://etherpad.openstack.org/p/ansible-summit-october-2018
  2. Attending in person: https://www.eventbrite.com/e/ansible-contributor-conference-austin-2018-tickets-48557063484 then use discount code to sign up to AnsibleFest
  3. Attending in person OR virtually: Add your name to the end of https://etherpad.openstack.org/p/ansible-summit-october-2018
  4. Happy automating!

Questions?

Thanks for all of your contributions to Ansible, and we hope to see you in Austin! And if you have any questions at all, please let us know.

Speak to gundalow on Freenode, or anyone else in #ansible-devel

@Akasurde
Copy link
Member Author

@Akasurde
Copy link
Member Author

@Tomorrow9
Copy link

PR to discuss:

@stroobl
Copy link

stroobl commented Aug 31, 2018

PR to discuss:

@Akasurde
Copy link
Member Author

Akasurde commented Sep 3, 2018

No discussion.

@Akasurde Akasurde changed the title VMware Working Group meeting agenda - Sept '17 to June 2018 VMware Working Group meeting agenda - Sept '17 to Sept 2018 Sep 3, 2018
@Akasurde
Copy link
Member Author

No discussion

@agowa
Copy link

agowa commented Oct 8, 2018

PR to discuss:
ansible/ansible#46625

@Akasurde
Copy link
Member Author

Akasurde commented Oct 8, 2018

Meeting ended Mon Oct 8 17:11:11 2018 UTC

@dagwieers
Copy link
Contributor

There is a need to have more consistent module parameters for the VMware modules as discussed here: ansible/ansible#46225 (comment)
And we can leave aliases for the original parameter names.

@dagwieers dagwieers mentioned this issue Oct 9, 2018
Merged
@Akasurde Akasurde changed the title VMware Working Group meeting agenda - Sept '17 to Sept 2018 VMware Working Group meeting agenda - Sept '17 to Oct 2018 Oct 15, 2018
@Akasurde
Copy link
Member Author

@Akasurde
Copy link
Member Author

@Akasurde
Copy link
Member Author

@Akasurde Akasurde changed the title VMware Working Group meeting agenda - Sept '17 to Oct 2018 VMware Working Group meeting agenda - Sept '17 to Nov 2018 Nov 19, 2018
@Akasurde
Copy link
Member Author

@agowa
Copy link

agowa commented Nov 23, 2018

For the next meeting, can you please give me some feedback on #46625? What is the process for it being merged? Is there anything that needs to be done before it can be merged? I guess so, as it has not been merged yet.

@Akasurde
Copy link
Member Author

Akasurde commented Dec 3, 2018

@Akasurde
Copy link
Member Author

PR to discuss -

@Akasurde
Copy link
Member Author

No discussion

@Akasurde Akasurde changed the title VMware Working Group meeting agenda - Sept '17 to Nov 2018 VMware Working Group meeting agenda - Sept '17 to Dec 2018 Dec 10, 2018
@Akasurde Akasurde mentioned this issue Jan 14, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Akasurde Akasurde

@jctanner jctanner

Labels
meeting_agenda vmware VMware community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests