Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update advanced search key options to be grouped #7741

Closed
jlmitch5 opened this issue Jul 28, 2020 · 2 comments
Closed

Update advanced search key options to be grouped #7741

jlmitch5 opened this issue Jul 28, 2020 · 2 comments

Comments

@jlmitch5
Copy link
Contributor

jlmitch5 commented Jul 28, 2020

patternfly/patternfly-react#4622 -- blocked until this PR merges and we update to get that code

Currently, there are two sets of keys displayed in the options for this typeahead--the direct keys of the resource, and the related search fields. Since there is currently a bug with PF support of select groups with typeaheads, I have to concat and dedup these two list of options together.

Related to this work, the related search fields are special in that when no prefix or lookup is specified, we want to allow the user to access the fuzzy search for these related resources, so I append the __search lookup when that is the case. Because there are some cases where a related key is both a direct key (usually the id of which resource it is connected to), as well as a related search key with which you can search the fields of that resource, I do not do the __search appending if it is in both sets of options.

So the work involved here is:

@unlikelyzero
Copy link

@jlmitch5 @mabashian @wenottingham removing state:blocked as the upstream pf PR component has merged

@tiagodread
Copy link
Contributor

This was addressed by #11208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants