-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import/export modules #7329
Comments
@john-westcott-iv already has some material for this. |
We are writing import/export modules here #6125 |
@john-westcott-iv is there a branch or PR for this work somewhere? |
https://github.com/jbradberry/awx/pull/3 b1d83dd...john-westcott-iv:import-export-collection That is relative to @jbradberry's import/export branch, which has changed in the meantime. Rebasing it may or may not work, squashing and cherry-picking might be better, and even that would introduce a lot of conflicts. The original work started with refactoring some of the base class, and other lighter parallel refactoring has happened elsewhere. We do need to swap out the logic for making requests, login, and logout. However, we still need to share the code for processing the authentication parameter processing. Even with awxkit, IIRC, you still initialize your own client/connection/session/whatever it is. This was the non-obvious thing that took me a while to accept. |
@ryanpetrello The modules are stuck in some PR gridlock: We need #7286 (lookup plugins) to go in. |
Maybe some updated version of #6615, my concerns about that refactor are specifically due to this awxkit integration. The The logic that awxkit will re-implement will be specifically login/logout/make_request, but even that seems like too much. Will these modules create a new token if given username/password? That's not something the AWX CLI does. There is a lot of logic around handling error codes, and that may be left to awxkit to raise exceptions. I'm curious what other people envision for this. The collection will be primed for refactoring after we the details hashed out about what responsibilities lie where. awxkit has a completely independent code lineage from the collection, and because of that, it sends us back to basic design questions. |
PR: #7799 |
ISSUE TYPE
Add to the tower collection modules that perform import/export type things.
Open Questions:
force: true
needs more fleshing out
related to #5146
The text was updated successfully, but these errors were encountered: