Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

"winrm" component should get a windows label #567

Closed
jctanner opened this issue Jun 9, 2017 · 5 comments
Closed

"winrm" component should get a windows label #567

jctanner opened this issue Jun 9, 2017 · 5 comments

Comments

@jctanner
Copy link
Contributor

jctanner commented Jun 9, 2017

ansible/ansible#25532

@jctanner
Copy link
Contributor Author

@Akasurde were you still working on this?

@Akasurde
Copy link
Member

I tried but no luck. You can take it.

@dagwieers
Copy link
Contributor

I looked at this as well, but it is unclear to me where these component/label-mappings are defined.

@jctanner
Copy link
Contributor Author

jctanner commented May 4, 2018

This can be implemented as a keyword in botmeta now.

https://github.com/ansible/ansible/blob/devel/.github/BOTMETA.yml#L1008-L1011

For example:

  lib/ansible/plugins/connection/winrm.py:
    maintainers: $team_windows_core
    keywords: winrm
    labels:
        - windows

@jctanner jctanner closed this as completed May 4, 2018
@dagwieers
Copy link
Contributor

Sweet !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants