Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.10] Fix missing ansible.builtin FQCNs in hardcoded action names #72457

Merged
merged 2 commits into from
Dec 7, 2020
Merged

[2.10] Fix missing ansible.builtin FQCNs in hardcoded action names #72457

merged 2 commits into from
Dec 7, 2020

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Nov 3, 2020 •
edited
Loading

SUMMARY

Backport of #71824 and #72471 to stable-2.10.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

core

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utilities Utilities category labels Nov 3, 2020
@felixfontein
Fix missing ansible.builtin FQCNs in hardcoded action names (ansible#…
199ebdc 
…71824)

* Make sure hard-coded action names also check for FQCN.
* Use _add_internal_fqcn() to avoid hardcoded lists and typoes.

(cherry picked from commit da60525)
@felixfontein felixfontein mentioned this pull request Nov 4, 2020
Merged
@felixfontein
Replace some more FQCNs.
af81d32 
(cherry picked from commit 72302dd)
@felixfontein
Copy link
Contributor Author

/rebuild_failed

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 5, 2020
@felixfontein
Copy link
Contributor Author

/rebuild_failed

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 6, 2020
@xanmanning xanmanning mentioned this pull request Nov 9, 2020
Closed
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. has_issue labels Nov 14, 2020
@mkrizek mkrizek mentioned this pull request Nov 27, 2020
Closed
@felixfontein felixfontein reopened this Dec 3, 2020
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 3, 2020
@relrod relrod merged commit 27f547b into ansible:stable-2.10 Dec 7, 2020
@felixfontein felixfontein deleted the backport/2.10/71824 branch December 8, 2020 05:34
@felixfontein
Copy link
Contributor Author

@relrod thanks again!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 8, 2020
@ansible ansible locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utilities Utilities category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @sivel @relrod @ansibot