size[block]: Limit the maximum block depth

[cidrblock]

Starting to pull in possible rule ideas from the community of practice: redhat-cop/automation-good-practices#64

Ofter, using an include within a block leads to more readable playbooks and task file vs. a deep block depth.

It might not be possible to check across files and I'm not sure lint tracks block state, but within a single file we should be able to limit it.

2 was suggested only as a starting point

[Ruchip16]

@ssbarnea I can try fixing this

[ssbarnea]

@Ruchip16 Any updates on it? Asking as I might do it myself if you don't have time.

[Ruchip16]

hey, yes I can try doing it, actually you said that you would assign me this issue after adding to the ansible org, so I was waiting for that but nevertheless, i would start now.

[ssbarnea]

This one should be easy to implement via matchtask() and checking if passed task is a block. When is a block, we can count how many direct entries are under it and trigger the rule.

If we have >20 items, we can raise "Replace long block with an include_tasks to make code easier to maintain."