From a6d5e99fe918047330c8cc9478235dfbad1b556f Mon Sep 17 00:00:00 2001
From: Sorin Sbarnea <ssbarnea@redhat.com>
Date: Fri, 12 Mar 2021 08:49:09 +0000
Subject: [PATCH] Avoid pre-run errors when role-name is disabled (#1459)

- when `role-name` is added to skip_list, just install simple role name
- when `role-name` is added to warn_list, display warning and continue
  execution.

Fixes: #1454
---
 .ansible-lint              |  1 +
 src/ansiblelint/_prerun.py | 47 +++++++++++++++++++++++---------------
 src/ansiblelint/cli.py     |  2 +-
 3 files changed, 31 insertions(+), 19 deletions(-)

diff --git a/.ansible-lint b/.ansible-lint
index b46e20aecb7..c684fbb8fe5 100644
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -42,6 +42,7 @@ warn_list:
   - skip_this_tag
   - git-latest
   - experimetal  # experimental is included in the implicit list
+  # - role-name
 
 # Offline mode disables installation of requirements.yml
 offline: false
diff --git a/src/ansiblelint/_prerun.py b/src/ansiblelint/_prerun.py
index 7429a291d50..bfde0b77e4b 100644
--- a/src/ansiblelint/_prerun.py
+++ b/src/ansiblelint/_prerun.py
@@ -141,7 +141,7 @@ def prepare_environment() -> None:
                 stderr=subprocess.STDOUT,
             )
             if run.returncode != 0:
-                _logger.error(run.stdout, file=sys.stderr)
+                _logger.error(run.stdout)
                 sys.exit(run.returncode)
 
     _install_galaxy_role()
@@ -163,23 +163,34 @@ def _install_galaxy_role() -> None:
     if not role_name:
         role_name = pathlib.Path(".").absolute().name
         role_name = re.sub(r'^{0}'.format(re.escape('ansible-role-')), '', role_name)
-    fqrn = f"{role_namespace}.{role_name}"
-    if not re.match(r"[a-z0-9][a-z0-9_]+\.[a-z][a-z0-9_]+$", fqrn):
-        _logger.error(
-            """\
-Computed fully qualified role name of %s is not valid.
-Please edit meta/main.yml and assure we can correctly determine full role name:
-
-galaxy_info:
-  role_name: my_name  # if absent directory name hosting role is used instead
-  namespace: my_galaxy_namespace  # if absent, author is used instead
-
-Namespace: https://galaxy.ansible.com/docs/contributing/namespaces.html#galaxy-namespace-limitations
-Role: https://galaxy.ansible.com/docs/contributing/creating_role.html#role-names
-""",
-            fqrn,
-        )
-        sys.exit(INVALID_PREREQUISITES_RC)
+
+    if 'role-name' not in options.skip_list:
+        fqrn = f"{role_namespace}.{role_name}"
+        if not re.match(r"[a-z0-9][a-z0-9_]+\.[a-z][a-z0-9_]+$", fqrn):
+            msg = (
+                """\
+    Computed fully qualified role name of %s does not follow current galaxy requirements.
+    Please edit meta/main.yml and assure we can correctly determine full role name:
+
+    galaxy_info:
+    role_name: my_name  # if absent directory name hosting role is used instead
+    namespace: my_galaxy_namespace  # if absent, author is used instead
+
+    Namespace: https://galaxy.ansible.com/docs/contributing/namespaces.html#galaxy-namespace-limitations
+    Role: https://galaxy.ansible.com/docs/contributing/creating_role.html#role-names
+
+    As an alternative, you can add 'role-name' to either skip_list or warn_list.
+    """,
+                fqrn,
+            )
+            if 'role-name' in options.warn_list:
+                _logger.warning(msg)
+            else:
+                _logger.error(msg)
+                sys.exit(INVALID_PREREQUISITES_RC)
+    else:
+        # when 'role-name' is in skip_list, we stick to plain role names
+        fqrn = role_name
     p = pathlib.Path(f"{options.project_dir}/.cache/roles")
     p.mkdir(parents=True, exist_ok=True)
     link_path = p / f"{role_namespace}.{role_name}"
diff --git a/src/ansiblelint/cli.py b/src/ansiblelint/cli.py
index 57fb7a77d4f..ce6dd3a8f15 100644
--- a/src/ansiblelint/cli.py
+++ b/src/ansiblelint/cli.py
@@ -317,7 +317,7 @@ def merge_config(file_config: Dict[Any, Any], cli_config: Namespace) -> Namespac
         'rulesdir': [],
         'skip_list': [],
         'tags': [],
-        'warn_list': ['experimental'],
+        'warn_list': ['experimental', 'role-name'],
         'mock_modules': [],
         'mock_roles': [],
         'enable_list': [],