Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch pip-compile jobs to use uv pip compile #1755

Open
gotmax23 opened this issue Aug 13, 2024 · 0 comments · May be fixed by #2084
Open

ci: switch pip-compile jobs to use uv pip compile #1755

gotmax23 opened this issue Aug 13, 2024 · 0 comments · May be fixed by #2084
Labels
tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.

Comments

@gotmax23
Copy link
Collaborator

Once #1616 goes through, we should switch to using uv pip compile (written in Rust and much faster) instead of pip-compile for our dependency update jobs. See https://git.sr.ht/~gotmax23/fedrq/commit/f7c8c0ddc1014c25b6fac23f822cd2d691d98202 for an example of how I implemented this in another project I maintain.

@gotmax23 gotmax23 added the tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. label Aug 13, 2024
@ansible-documentation-bot ansible-documentation-bot bot added the needs_triage Needs a first human triage before being processed. label Aug 13, 2024
@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Oct 8, 2024
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Oct 29, 2024
This switches the nox pip-compile session and lockfiles to use uv pip
compile (written in Rust and much faster) instead of pip-compile from
pip-tools for our dependency update jobs.

As a side effect, this addresses the issue brought up in
ansible#1950 (comment),
as we're no longer using pip-compile that can break anytime pip changes
the private/internal APIs that pip-tools relies on.

I re-generated the lockfiles with `--no-upgrade` to avoid extraneous
changes in this PR.
The only additions are the formatting of comments in the lockfile and
colorama.
colorama was added as a result of `uv pip-compile`'s `--universal` flag
which creates "universal" lockfiles that include dependencies of other
platforms, architectures, and Python versions than those of the system
used to generate the lockfile.
`--universal` should create more consistent results for contributors who
use other systems
(e.g., Mac OS or a newer Python version than the one used in CI).

Fixes: ansible#1755
@gotmax23 gotmax23 linked a pull request Oct 29, 2024 that will close this issue
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Nov 23, 2024
This switches the nox pip-compile session and lockfiles to use uv pip
compile (written in Rust and much faster) instead of pip-compile from
pip-tools for our dependency update jobs.

As a side effect, this addresses the issue brought up in
ansible#1950 (comment),
as we're no longer using pip-compile that can break anytime pip changes
the private/internal APIs that pip-tools relies on.

I re-generated the lockfiles with `--no-upgrade` to avoid extraneous
changes in this PR.
The only additions are the formatting of comments in the lockfile and
colorama.
colorama was added as a result of `uv pip-compile`'s `--universal` flag
which creates "universal" lockfiles that include dependencies of other
platforms, architectures, and Python versions than those of the system
used to generate the lockfile.
`--universal` should create more consistent results for contributors who
use other systems
(e.g., Mac OS or a newer Python version than the one used in CI).

Fixes: ansible#1755
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Nov 23, 2024
This switches the nox pip-compile session and lockfiles to use uv pip
compile (written in Rust and much faster) instead of pip-compile from
pip-tools for our dependency update jobs.

As a side effect, this addresses the issue brought up in
ansible#1950 (comment),
as we're no longer using pip-compile that can break anytime pip changes
the private/internal APIs that pip-tools relies on.

I re-generated the lockfiles with `--no-upgrade` to avoid extraneous
changes in this PR.
The only additions are the formatting of comments in the lockfile and
colorama.
colorama was added as a result of `uv pip-compile`'s `--universal` flag
which creates "universal" lockfiles that include dependencies of other
platforms, architectures, and Python versions than those of the system
used to generate the lockfile.
`--universal` should create more consistent results for contributors who
use other systems
(e.g., Mac OS or a newer Python version than the one used in CI).

Fixes: ansible#1755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Projects
Status: 🆕 Triage
Development

Successfully merging a pull request may close this issue.

2 participants