Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycloak_quarkus: skip proxy config if keycloak_quarkus_proxy_mode is none #109

Merged
merged 2 commits into from
Sep 19, 2023
Merged

keycloak_quarkus: skip proxy config if keycloak_quarkus_proxy_mode is none #109

merged 2 commits into from
Sep 19, 2023

Conversation

msherman13
Copy link

@msherman13 msherman13 commented Sep 18, 2023 •
edited by guidograzioli
Loading

Variable Description Default
keycloak_quarkus_proxy_mode The proxy address forwarding mode if the server is behind a reverse proxy. Allowed values are: [ none, edge, reencrypt, passthrough ] edge

Fix #108

@msherman13 msherman13 mentioned this pull request Sep 18, 2023
Closed
@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Sep 18, 2023
@guidograzioli
Copy link
Member

Thanks for the PR; please also update the doc here and here

@msherman13
Copy link
Author

@guidograzioli updated

guidograzioli
guidograzioli approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidograzioli guidograzioli changed the title quarkus role: do not populate proxy to config if keycloak_quarkus_pro… keycloak_quarkus: disable proxy config when keycloak_quarkus_proxy_mode is none Sep 19, 2023
@guidograzioli guidograzioli changed the title keycloak_quarkus: disable proxy config when keycloak_quarkus_proxy_mode is none keycloak_quarkus: skip proxy config if keycloak_quarkus_proxy_mode is none Sep 19, 2023
@guidograzioli guidograzioli merged commit bef20b6 into ansible-middleware:main Sep 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keycloak_quarkus fails to start upon installation
2 participants
@msherman13 @guidograzioli