Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service availability wait after restart not happening by default #233

Closed
gionn opened this issue Jun 4, 2024 · 3 comments · Fixed by #234
Closed

Service availability wait after restart not happening by default #233

gionn opened this issue Jun 4, 2024 · 3 comments · Fixed by #234

Comments

@gionn
Copy link
Contributor

gionn commented Jun 4, 2024

SUMMARY

Hello,

after upgrading this collection:

   - name: middleware_automation.keycloak
-    version: 2.1.2
+    version: 2.3.0

I got a failure in my playbook because I have some tasks to configure realm/clients upon the execution of this collection, because the keycloak service was (not yet) up and running upon first (re)start.

After setting keycloak_quarkus_restart_health_check: true, I've got the old behaviour for which the role do an active wait for the service to be available.

What's the reason for having it optional?

@guidograzioli
Copy link
Member

A major overhaul of the HA scenario happened; I guess at some point the flag turned from always true, to true only is ha_enabled is true. See: #231 and #199

Totally open for discussing flicking it back to always true

@gionn
Copy link
Contributor Author

gionn commented Jun 4, 2024

I took a quick look and seems safe to switch the default to true, raised a PR

@guidograzioli
Copy link
Member

I'll bump to 2.4.0 and release as soon the CI finishes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants