-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak CI #260
Merged
Merged
Unbreak CI #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
apatard
commented
Aug 2, 2024
- Upgrade containers and boxes to use newer versions
- Remove create.yml/destroy.yml templates copied by molecule with molecule init for unlucky plugins
- Rename vagrant tests to avoid "import vagrant" in the test importing the test module instead of importing the vagrant module.
- Move the vagrant box_url testing to its own test to avoid failures in multi-node where it would be hard to know if the issue is with the test or with the box_url test.
- Upgrade containers and boxes to use newer versions - Remove create.yml/destroy.yml templates copied by molecule with molecule init for unlucky plugins - Rename vagrant tests to avoid "import vagrant" in the test importing the test module instead of importing the vagrant module. - Move the vagrant box_url testing to its own test to avoid failures in multi-node where it would be hard to know if the issue is with the test or with the box_url test. Signed-off-by: Arnaud Patard <[email protected]>
for more information, see https://pre-commit.ci
matt-horwood-mayden
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, can we merge
@matt-horwood-mayden well, a review from someone with write access is needed. |
hello! gentle bump on this @ssbarnea @cidrblock |
oraNod
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ssbarnea
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.