Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playbooks/build-single-release.yaml should perform strict metadata verification #577

Open
webknjaz opened this issue Feb 5, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@webknjaz
Copy link
Member

webknjaz commented Feb 5, 2024

This playbook builds the dists but doesn't perform the metadata validation. That must happen early in the process. Specifically, calling twine check --strict must succeed. My pypi-upload action is invoked late in the process and it does perform a non-strict check, which may fail the upload last moment which would be unpleasant. The PyPI backend might also reject uploads because of the problems with dists, some of which (but not all) can be caught in the strict mode.
Running the check as early as possible (on merges to main and pull requests) reveals metadata problems in a way that they can be fixed before attempting to build though this workflow.

Putting it into the playbook would be useful. Something that could abort a release with broken meta.

Originally posted by @webknjaz in ansible-community/ansible-build-data#265 (comment)

@gotmax23 gotmax23 added the good first issue Good for newcomers label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants