Allow user to specify namespace for standalone roles #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows user to specify the desired namespace under which the role is expected to be published. This allows us to better test the role as it was installed, including performing syntax check on test playbooks. Previous implementation was forcing user to convert its author field to a namespace compatible string. We no longer need this as galaxy-importer does not have any problem when it encounters unknown fields. Namespace is also used in collections, so it would be easier for to remember for users.
This was referenced Mar 11, 2021
Merged
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to specify the desired namespace under which the role will be published. This allows us to better test
the role as it was installed, including performing syntax check on test playbooks.
Previous implementation was forcing user to convert its author field to a namespace compatible string. We no longer need this as galaxy-importer does not have any problem when it encounters unknown
fields. Namespace is also used in collections, so it would be easier for to remember for users.