Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mellanox.onyx collection on Ansible Galaxy #24

Open
leosala opened this issue Jun 22, 2022 · 9 comments
Open

Update mellanox.onyx collection on Ansible Galaxy #24

leosala opened this issue Jun 22, 2022 · 9 comments

Comments

@leosala
Copy link

leosala commented Jun 22, 2022

SUMMARY

It would be nice to have an updated version of the collection on Galaxy, as the corrent one is outdated and has issues with Ansible latest releases. This is a very useful tool for us, and we greatly appreciate the effort in maintaining it!

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

mellanox.onyx

ADDITIONAL INFORMATION
@Andersson007
Copy link
Contributor

CC @samerd @thedoubl3j could you please take a look? The community is on the verge of removing the collection from the package.

@thedoubl3j
Copy link

will default to @samerd as this is a partner maintained collection

@mariolenz
Copy link
Contributor

This collection is currently unmaintained, so nobody will work on your issue. See ansible-community/community-topics#136 for more information.

If you're interested in mainting this collection yourself, please read the maintainer guidelines and let us know if you want to take over on Matrix: #community:ansible.com or on irc.libera.chat: #ansible-community.

@ericpulvino
Copy link

@leosala Can you identify what kinds of specific issues you're having with latest ansible? (We're investigating the effort needed to address them.)

@leosala
Copy link
Author

leosala commented Dec 8, 2022

@ericpulvino here is what I get:

[WARNING]: The "ansible_collections.ansible.netcommon.plugins.connection.network_cli" connection plugin has an improperly configured remote target value, forcing "inventory_hostname" templated value instead
of the string
ok: [ib-edge-13.psi.ch] => {
    "output": {
        "changed": false,
        "failed": false,
        "stdout": [
            "Product name:     XXXXXXXXXXXXXXX"
        ],
        "stdout_lines": [
            [
                "Product name:      MLNX-OS",
[...]
            ]
        ]
    }
}
ERROR! Unexpected Exception, this is probably a bug: No module named 'ansible.plugins.action.network'

This was solved here: 45c3f9a - so one would only need to keep the collection updated on Galaxy I believe?

This is the Ansible version:

$ ansible --version
ansible [core 2.14.1]
  config file = /home/sala/Work/GIT/psi/hpc-sysadmins/playbooks/ansible.cfg
  configured module search path = ['/home/sala/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/sala/Programs/anaconda3/envs/ansible-latest/lib/python3.11/site-packages/ansible
  ansible collection location = /home/sala/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/sala/Programs/anaconda3/envs/ansible-latest/bin/ansible
  python version = 3.11.0 | packaged by conda-forge | (main, Oct 25 2022, 06:24:40) [GCC 10.4.0] (/home/sala/Programs/anaconda3/envs/ansible-latest/bin/python)
  jinja version = 3.1.2
  libyaml = True

and the actual task being executed:

    - name: "Showing ONYX version"
      onyx_command:
        commands: show version
      register: output
      changed_when: false

@FlorianHeigl
Copy link

@ericpulvino is the assessment made easier by noting that it's not going to work for anyone at all?

@FlorianHeigl
Copy link

FlorianHeigl commented May 11, 2023

To get out of this bind, and jump to a non-broken version:
follow
https://docs.ansible.com/ansible/latest/collections_guide/collections_installing.html

Effectively, this means using:

$ git clone https://github.com/ansible-collections/mellanox.onyx.git
$ ansible-galaxy collection install git+file://$PWD/mellanox.onyx/ --force

cc / @lukebates123

@leosala
Copy link
Author

leosala commented Dec 5, 2023

@ericpulvino is there any further engagement / efforts being put by Nvidia on this?

@FlorianHeigl
Copy link

FlorianHeigl commented Dec 7, 2023

@samerd too, it would really help if the little steps here could be done. the effort for ongoing maintenance should be committed so people can use this and keep building things with the switches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants