From 5444f39366c38bbbbba6623d0041c68d314131e5 Mon Sep 17 00:00:00 2001 From: Andrew Klychkov Date: Thu, 7 Apr 2022 09:12:44 +0200 Subject: [PATCH 1/5] Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt --- tests/sanity/ignore-2.14.txt | 105 +++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 tests/sanity/ignore-2.14.txt diff --git a/tests/sanity/ignore-2.14.txt b/tests/sanity/ignore-2.14.txt new file mode 100644 index 0000000..cd17349 --- /dev/null +++ b/tests/sanity/ignore-2.14.txt @@ -0,0 +1,105 @@ +plugins/modules/onyx_bgp.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_bgp.py validate-modules:doc-missing-type +plugins/modules/onyx_bgp.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_buffer_pool.py validate-modules:doc-missing-type +plugins/modules/onyx_buffer_pool.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_command.py validate-modules:doc-missing-type +plugins/modules/onyx_command.py validate-modules:parameter-list-no-elements +plugins/modules/onyx_command.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_config.py validate-modules:doc-missing-type +plugins/modules/onyx_config.py validate-modules:parameter-list-no-elements +plugins/modules/onyx_config.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_facts.py validate-modules:parameter-list-no-elements +plugins/modules/onyx_facts.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_igmp.py validate-modules:doc-missing-type +plugins/modules/onyx_igmp.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_igmp_interface.py validate-modules:doc-missing-type +plugins/modules/onyx_igmp_vlan.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_igmp_vlan.py validate-modules:doc-missing-type +plugins/modules/onyx_igmp_vlan.py validate-modules:doc-required-mismatch +plugins/modules/onyx_igmp_vlan.py validate-modules:parameter-list-no-elements +plugins/modules/onyx_igmp_vlan.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_interface.py validate-modules:doc-choices-do-not-match-spec +plugins/modules/onyx_interface.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_interface.py validate-modules:doc-missing-type +plugins/modules/onyx_interface.py validate-modules:doc-required-mismatch +plugins/modules/onyx_interface.py validate-modules:missing-suboption-docs +plugins/modules/onyx_interface.py validate-modules:nonexistent-parameter-documented +plugins/modules/onyx_interface.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_interface.py validate-modules:undocumented-parameter +plugins/modules/onyx_l2_interface.py validate-modules:doc-choices-do-not-match-spec +plugins/modules/onyx_l2_interface.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_l2_interface.py validate-modules:doc-missing-type +plugins/modules/onyx_l2_interface.py validate-modules:doc-required-mismatch +plugins/modules/onyx_l2_interface.py validate-modules:missing-suboption-docs +plugins/modules/onyx_l2_interface.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_l2_interface.py validate-modules:undocumented-parameter +plugins/modules/onyx_l3_interface.py validate-modules:doc-choices-do-not-match-spec +plugins/modules/onyx_l3_interface.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_l3_interface.py validate-modules:doc-missing-type +plugins/modules/onyx_l3_interface.py validate-modules:doc-required-mismatch +plugins/modules/onyx_l3_interface.py validate-modules:missing-suboption-docs +plugins/modules/onyx_l3_interface.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_l3_interface.py validate-modules:undocumented-parameter +plugins/modules/onyx_linkagg.py validate-modules:doc-choices-do-not-match-spec +plugins/modules/onyx_linkagg.py validate-modules:doc-default-does-not-match-spec +plugins/modules/onyx_linkagg.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_linkagg.py validate-modules:doc-missing-type +plugins/modules/onyx_linkagg.py validate-modules:doc-required-mismatch +plugins/modules/onyx_linkagg.py validate-modules:missing-suboption-docs +plugins/modules/onyx_linkagg.py validate-modules:parameter-list-no-elements +plugins/modules/onyx_linkagg.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_linkagg.py validate-modules:undocumented-parameter +plugins/modules/onyx_lldp.py validate-modules:doc-missing-type +plugins/modules/onyx_lldp_interface.py validate-modules:doc-choices-do-not-match-spec +plugins/modules/onyx_lldp_interface.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_lldp_interface.py validate-modules:doc-missing-type +plugins/modules/onyx_lldp_interface.py validate-modules:doc-required-mismatch +plugins/modules/onyx_lldp_interface.py validate-modules:missing-suboption-docs +plugins/modules/onyx_lldp_interface.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_lldp_interface.py validate-modules:undocumented-parameter +plugins/modules/onyx_magp.py validate-modules:doc-missing-type +plugins/modules/onyx_magp.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_mlag_ipl.py validate-modules:doc-missing-type +plugins/modules/onyx_mlag_vip.py validate-modules:doc-default-does-not-match-spec +plugins/modules/onyx_mlag_vip.py validate-modules:doc-missing-type +plugins/modules/onyx_mlag_vip.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_ntp.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_ntp_servers_peers.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_ospf.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_ospf.py validate-modules:doc-missing-type +plugins/modules/onyx_ospf.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_pfc_interface.py validate-modules:doc-choices-do-not-match-spec +plugins/modules/onyx_pfc_interface.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_pfc_interface.py validate-modules:doc-missing-type +plugins/modules/onyx_pfc_interface.py validate-modules:doc-required-mismatch +plugins/modules/onyx_pfc_interface.py validate-modules:missing-suboption-docs +plugins/modules/onyx_pfc_interface.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_pfc_interface.py validate-modules:undocumented-parameter +plugins/modules/onyx_protocol.py validate-modules:doc-missing-type +plugins/modules/onyx_ptp_global.py validate-modules:doc-missing-type +plugins/modules/onyx_ptp_global.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_ptp_interface.py validate-modules:doc-missing-type +plugins/modules/onyx_ptp_interface.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_qos.py validate-modules:doc-missing-type +plugins/modules/onyx_qos.py validate-modules:parameter-list-no-elements +plugins/modules/onyx_qos.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_snmp.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_snmp_hosts.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_snmp_users.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_syslog_remote.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_traffic_class.py validate-modules:doc-missing-type +plugins/modules/onyx_traffic_class.py validate-modules:parameter-list-no-elements +plugins/modules/onyx_traffic_class.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_vlan.py validate-modules:doc-choices-do-not-match-spec +plugins/modules/onyx_vlan.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_vlan.py validate-modules:doc-missing-type +plugins/modules/onyx_vlan.py validate-modules:doc-required-mismatch +plugins/modules/onyx_vlan.py validate-modules:missing-suboption-docs +plugins/modules/onyx_vlan.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_vlan.py validate-modules:undocumented-parameter +plugins/modules/onyx_vxlan.py validate-modules:doc-elements-mismatch +plugins/modules/onyx_vxlan.py validate-modules:doc-required-mismatch +plugins/modules/onyx_vxlan.py validate-modules:missing-suboption-docs +plugins/modules/onyx_vxlan.py validate-modules:parameter-type-not-in-doc +plugins/modules/onyx_vxlan.py validate-modules:undocumented-parameter From 827c183b6e73d1b12423b7edb4ef6b8f38ec83b8 Mon Sep 17 00:00:00 2001 From: Andrew Klychkov Date: Fri, 22 Apr 2022 09:11:44 +0200 Subject: [PATCH 2/5] cliconf/onyx.py: fix sanity --- plugins/cliconf/onyx.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/cliconf/onyx.py b/plugins/cliconf/onyx.py index 0e7df54..90b85b0 100644 --- a/plugins/cliconf/onyx.py +++ b/plugins/cliconf/onyx.py @@ -21,7 +21,7 @@ DOCUMENTATION = """ --- -cliconf: onyx +name: onyx short_description: Use onyx cliconf to run command on Mellanox ONYX platform description: - This onyx plugin provides low level abstraction apis for From 82c33332cfa8b1a9d9ddf66f9f576df530eb1b33 Mon Sep 17 00:00:00 2001 From: Andrew Klychkov Date: Fri, 22 Apr 2022 09:17:39 +0200 Subject: [PATCH 3/5] cliconf/onyx.py: fix sanity version_added --- plugins/cliconf/onyx.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/cliconf/onyx.py b/plugins/cliconf/onyx.py index 90b85b0..aefbde6 100644 --- a/plugins/cliconf/onyx.py +++ b/plugins/cliconf/onyx.py @@ -26,7 +26,7 @@ description: - This onyx plugin provides low level abstraction apis for sending and receiving CLI commands from Mellanox ONYX network devices. -version_added: "2.5" +version_added: "2.5.0" """ import json From 365ae8fa099afe8e8edf419fe4b5059e5519e3c4 Mon Sep 17 00:00:00 2001 From: Andrew Klychkov Date: Fri, 22 Apr 2022 09:34:55 +0200 Subject: [PATCH 4/5] Fix sanity --- plugins/modules/onyx_command.py | 2 +- plugins/modules/onyx_facts.py | 2 +- plugins/modules/onyx_ntp.py | 2 ++ plugins/modules/onyx_ntp_servers_peers.py | 2 ++ plugins/modules/onyx_snmp.py | 2 ++ plugins/modules/onyx_snmp_hosts.py | 1 + plugins/modules/onyx_snmp_users.py | 1 + plugins/modules/onyx_syslog_remote.py | 1 + 8 files changed, 11 insertions(+), 2 deletions(-) diff --git a/plugins/modules/onyx_command.py b/plugins/modules/onyx_command.py index 719e8f2..d1f308e 100644 --- a/plugins/modules/onyx_command.py +++ b/plugins/modules/onyx_command.py @@ -18,7 +18,7 @@ argument that will cause the module to wait for a specific condition before returning or timing out if the condition is not met. - This module does not support running commands in configuration mode. - Please use M(onyx_config) to configure Mellanox ONYX devices. + Please use M(mellanox.onyx.onyx_config) to configure Mellanox ONYX devices. notes: - Tested on ONYX 3.6.4000 options: diff --git a/plugins/modules/onyx_facts.py b/plugins/modules/onyx_facts.py index 997d4df..9ecf72f 100644 --- a/plugins/modules/onyx_facts.py +++ b/plugins/modules/onyx_facts.py @@ -26,7 +26,7 @@ to a given subset. Possible values for this argument include all, version, module, and interfaces. Can specify a list of values to include a larger subset. Values can also be used - with an initial C(M(!)) to specify that a specific subset should + with an initial C(!) to specify that a specific subset should not be collected. required: false default: version diff --git a/plugins/modules/onyx_ntp.py b/plugins/modules/onyx_ntp.py index 6105f03..b0de45a 100644 --- a/plugins/modules/onyx_ntp.py +++ b/plugins/modules/onyx_ntp.py @@ -28,6 +28,7 @@ type: str ntp_authentication_keys: type: list + elements: dict description: - List of ntp authentication keys suboptions: @@ -54,6 +55,7 @@ type: str trusted_keys: type: list + elements: int description: - List of ntp trusted keys ''' diff --git a/plugins/modules/onyx_ntp_servers_peers.py b/plugins/modules/onyx_ntp_servers_peers.py index f49daa2..0328855 100644 --- a/plugins/modules/onyx_ntp_servers_peers.py +++ b/plugins/modules/onyx_ntp_servers_peers.py @@ -17,6 +17,7 @@ options: peer: type: list + elements: dict description: - List of ntp peers. suboptions: @@ -45,6 +46,7 @@ type: str server: type: list + elements: dict description: - List of ntp servers. suboptions: diff --git a/plugins/modules/onyx_snmp.py b/plugins/modules/onyx_snmp.py index 895d003..2367a6b 100644 --- a/plugins/modules/onyx_snmp.py +++ b/plugins/modules/onyx_snmp.py @@ -38,6 +38,7 @@ type: bool snmp_communities: type: list + elements: dict description: - List of snmp communities suboptions: @@ -96,6 +97,7 @@ type: bool snmp_permissions: type: list + elements: dict description: - Allow SNMPSET requests for items in a MIB. suboptions: diff --git a/plugins/modules/onyx_snmp_hosts.py b/plugins/modules/onyx_snmp_hosts.py index 93facf7..5d5f6f0 100644 --- a/plugins/modules/onyx_snmp_hosts.py +++ b/plugins/modules/onyx_snmp_hosts.py @@ -18,6 +18,7 @@ options: hosts: type: list + elements: dict description: - List of snmp hosts suboptions: diff --git a/plugins/modules/onyx_snmp_users.py b/plugins/modules/onyx_snmp_users.py index 7feeb2a..00c49c2 100644 --- a/plugins/modules/onyx_snmp_users.py +++ b/plugins/modules/onyx_snmp_users.py @@ -18,6 +18,7 @@ options: users: type: list + elements: dict description: - List of snmp users suboptions: diff --git a/plugins/modules/onyx_syslog_remote.py b/plugins/modules/onyx_syslog_remote.py index ca3e45f..49543f0 100644 --- a/plugins/modules/onyx_syslog_remote.py +++ b/plugins/modules/onyx_syslog_remote.py @@ -39,6 +39,7 @@ description: - Override log levels for this sink on a per-class basis type: list + elements: dict suboptions: override_class: description: From 20c96d1d94906184f9c57f787e785a1d8cb948d7 Mon Sep 17 00:00:00 2001 From: Andrew Klychkov Date: Fri, 22 Apr 2022 09:39:51 +0200 Subject: [PATCH 5/5] Remove unnecessary lines from ignore.txt --- tests/sanity/ignore-2.14.txt | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/sanity/ignore-2.14.txt b/tests/sanity/ignore-2.14.txt index cd17349..73b5da1 100644 --- a/tests/sanity/ignore-2.14.txt +++ b/tests/sanity/ignore-2.14.txt @@ -64,8 +64,6 @@ plugins/modules/onyx_mlag_ipl.py validate-modules:doc-missing-type plugins/modules/onyx_mlag_vip.py validate-modules:doc-default-does-not-match-spec plugins/modules/onyx_mlag_vip.py validate-modules:doc-missing-type plugins/modules/onyx_mlag_vip.py validate-modules:parameter-type-not-in-doc -plugins/modules/onyx_ntp.py validate-modules:doc-elements-mismatch -plugins/modules/onyx_ntp_servers_peers.py validate-modules:doc-elements-mismatch plugins/modules/onyx_ospf.py validate-modules:doc-elements-mismatch plugins/modules/onyx_ospf.py validate-modules:doc-missing-type plugins/modules/onyx_ospf.py validate-modules:parameter-type-not-in-doc @@ -84,10 +82,6 @@ plugins/modules/onyx_ptp_interface.py validate-modules:parameter-type-not-in-doc plugins/modules/onyx_qos.py validate-modules:doc-missing-type plugins/modules/onyx_qos.py validate-modules:parameter-list-no-elements plugins/modules/onyx_qos.py validate-modules:parameter-type-not-in-doc -plugins/modules/onyx_snmp.py validate-modules:doc-elements-mismatch -plugins/modules/onyx_snmp_hosts.py validate-modules:doc-elements-mismatch -plugins/modules/onyx_snmp_users.py validate-modules:doc-elements-mismatch -plugins/modules/onyx_syslog_remote.py validate-modules:doc-elements-mismatch plugins/modules/onyx_traffic_class.py validate-modules:doc-missing-type plugins/modules/onyx_traffic_class.py validate-modules:parameter-list-no-elements plugins/modules/onyx_traffic_class.py validate-modules:parameter-type-not-in-doc