Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support confirm option ito control commit/timer in Resource Modules #384

Open
3 tasks done
rohitthakur2590 opened this issue Mar 15, 2023 · 0 comments · May be fixed by #440
Open
3 tasks done

Support confirm option ito control commit/timer in Resource Modules #384

rohitthakur2590 opened this issue Mar 15, 2023 · 0 comments · May be fixed by #440
Assignees
@rohitthakur2590
Labels
feature This issue/PR relates to a feature request. has_pr This issue has an associated PR.

Comments

@rohitthakur2590
Copy link
Collaborator

rohitthakur2590 commented Mar 15, 2023 •
edited
Loading

SUMMARY

Implement supoprt for commit confirm with in Junos Resource Modules Which provides following advantages:

  • ability to revert changes if the playbook executes multiple Junos modules in a row and results are undesired.
  • leverage upon confirm commit feature supported by junos.
  • it can also help to reduce large CPU utilization.
ISSUE TYPE
  • Feature Idea
COMPONENT NAME
ADDITIONAL INFORMATION

The playbook could include task like these:

- name:  Try config and commit if everything is as planned
  hosts: junos
  collections:
    - junipernetworks.junos
  vars:
    ansible_junos_commit_confirmed: true
    ansible_junos_commit_confirmed_timeout: 5
  tasks:
  - name: Merge provided config into running-config
     junos_interfaces:
         config: "{{ l3_interfaces }}"

  - name: Merge provided config into running-config
     junos_interfaces:
         config: "{{ ospfv2}}"

   - name: Merge provided config into running-config
      junos_interfaces:
         config: "{{ ospf_interfaces }}"
        
   - name: Confirm Last Commits
      junos_config:
         confirm_commit: yes
@rohitthakur2590 rohitthakur2590 self-assigned this Mar 29, 2023
This was referenced Apr 3, 2023
Closed
Closed
@rohitthakur2590 rohitthakur2590 added the feature This issue/PR relates to a feature request. label Aug 16, 2023
@rohitthakur2590 rohitthakur2590 linked a pull request Aug 16, 2023 that will close this issue
Open
3 tasks
@rohitthakur2590 rohitthakur2590 changed the title Support Confirm Commit option in Resource Modules Support confirm Commit option in Resource Modules Aug 16, 2023
@rohitthakur2590 rohitthakur2590 changed the title Support confirm Commit option in Resource Modules Support confirm option ito control commit/timer in Resource Modules Aug 16, 2023
@rohitthakur2590 rohitthakur2590 added the has_pr This issue has an associated PR. label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitthakur2590 rohitthakur2590

Labels
feature This issue/PR relates to a feature request. has_pr This issue has an associated PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Commit Confirm Support For Resource Modules rohitthakur2590/junipernetworks.junos
1 participant
@rohitthakur2590