Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subnet logconfig prepare for 3.0.0 #42

Closed
wants to merge 0 commits into from
Closed

Subnet logconfig prepare for 3.0.0 #42

wants to merge 0 commits into from

Conversation

modular-magician
Copy link
Contributor

@modular-magician modular-magician mentioned this pull request Oct 31, 2019
Merged
@slevenick
Copy link
Collaborator

@rambleraptor the logConfig block conflicts with enableFlowLogs boolean. logConfig.enable MUST be the same as logConfig.enable which is not currently in api.yaml.

Should I exclude logConfig?

@rambleraptor
Copy link
Contributor

Little confused by this. logConfig.enable must be the same as logConfig.enable?

@slevenick
Copy link
Collaborator

Little confused by this. logConfig.enable must be the same as logConfig.enable?

Errrrr, logConfig.enable must match enableFlowLogs if both are specified. One of them must be true if you include any of the other settings in the logConfig block

@rambleraptor
Copy link
Contributor

Yeah, let's go ahead and exclude it and put in a TODO/GitHub bug. I'll need to figure out a deprecation story (which will be less long + windy in collections land)

@slevenick slevenick mentioned this pull request Nov 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambleraptor rambleraptor Awaiting requested review from rambleraptor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modular-magician @slevenick @rambleraptor