Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean when is wrong #395

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

lingfish
Copy link
Contributor

@lingfish lingfish commented Jun 7, 2021

SUMMARY

I think this is meant to not be "not".

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.zabbix

ADDITIONAL INFORMATION

I think this is meant to not be "not".
@dj-wasabi
Copy link
Contributor

@lingfish

To be honest, I don't know? (Not a Windows User so I don't know what that 'dot' does/means...)

@lingfish
Copy link
Contributor Author

lingfish commented Jun 7, 2021

Hi, it was #376 by @ironbishop that added it. Best that I can tell, they were trying to only run that task if zabbix_agent_win_include ended up being a string that looked like it had a dot in it, as in zabbix_agentd.d, following the standard of "dot d" include dirs.

@ironbishop
Copy link
Contributor

ironbishop commented Jun 10, 2021

True, i didn't account for the '.d' folder. But this check is meant to skip the folder creation when you want to include a single file, not a folder. Maybe something like '.conf' not in zabbix_agent_win_include would be better?

@dj-wasabi
Copy link
Contributor

So how do we continue? Shall I merge it, or will @lingfish update the PR with comment from @ironbishop ?

@ironbishop
Copy link
Contributor

i can't commit to his branch, but I can create my own if he's unable to go on with the change

@dj-wasabi
Copy link
Contributor

i can't commit to his branch, but I can create my own if he's unable to go on with the change

Ok! 👍
Will merge the PR. Thanks @lingfish and @ironbishop

@dj-wasabi dj-wasabi merged commit 5db749c into ansible-collections:main Jun 25, 2021
ironbishop added a commit to npotorino/community.zabbix that referenced this pull request Jun 26, 2021
dj-wasabi pushed a commit that referenced this pull request Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants