From dac3b79a17e35d1e89b1429f73a83d446dc5fe74 Mon Sep 17 00:00:00 2001 From: derdeagle Date: Fri, 24 Nov 2023 21:07:40 +0100 Subject: [PATCH] Fixes #230: Add missing DoH parameters in the "ip dns" path (#235) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - doh-max-concurrent-queries - doh-max-server-connections - doh-timeout The parameters mentioned above seem to be added in version 7.8 as far as I could tell from the changelogs. Co-authored-by: Johannes Münch --- changelogs/fragments/235-add-missing-dns-attributes.yml | 2 ++ plugins/module_utils/_api_data.py | 5 +++++ 2 files changed, 7 insertions(+) create mode 100644 changelogs/fragments/235-add-missing-dns-attributes.yml diff --git a/changelogs/fragments/235-add-missing-dns-attributes.yml b/changelogs/fragments/235-add-missing-dns-attributes.yml new file mode 100644 index 00000000..f2bf2f5e --- /dev/null +++ b/changelogs/fragments/235-add-missing-dns-attributes.yml @@ -0,0 +1,2 @@ +minor_changes: + - api_info, api_modify - add missing DoH parameters ``doh-max-concurrent-queries``, ``doh-max-server-connections``, and ``doh-timeout`` to the ``ip dns`` path (https://github.com/ansible-collections/community.routeros/issues/230, https://github.com/ansible-collections/community.routeros/pull/235) diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py index 50ad1d04..f786de8c 100644 --- a/plugins/module_utils/_api_data.py +++ b/plugins/module_utils/_api_data.py @@ -1873,6 +1873,11 @@ def join_path(path): unversioned=VersionedAPIData( single_value=True, fully_understood=True, + versioned_fields=[ + ([('7.8', '>=')], 'doh-max-concurrent-queries', KeyInfo(default=50)), + ([('7.8', '>=')], 'doh-max-server-connections', KeyInfo(default=5)), + ([('7.8', '>=')], 'doh-timeout', KeyInfo(default='5s')), + ], fields={ 'allow-remote-requests': KeyInfo(), 'cache-max-ttl': KeyInfo(default='1w'),