From 542a362ceef3b7e77592a4b5d0c861dbaf4eef3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCnch?= Date: Thu, 1 Feb 2024 18:48:14 +0100 Subject: [PATCH] Fixes #256: make path `user group` modifiable and add `comment` attribute (#257) * Fixes #256: make path `user group` modifiable and add `comment` attribute` Add changelog fragment * Update changelogs/fragments/257-make-user_group-modifiable.yml Co-authored-by: Felix Fontein --------- Co-authored-by: Felix Fontein --- changelogs/fragments/257-make-user_group-modifiable.yml | 2 ++ plugins/module_utils/_api_data.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/257-make-user_group-modifiable.yml diff --git a/changelogs/fragments/257-make-user_group-modifiable.yml b/changelogs/fragments/257-make-user_group-modifiable.yml new file mode 100644 index 00000000..06de81eb --- /dev/null +++ b/changelogs/fragments/257-make-user_group-modifiable.yml @@ -0,0 +1,2 @@ +minor_changes: + - api_info, api_modify - make path ``user group`` modifiable and add ``comment`` attribute (https://github.com/ansible-collections/community.routeros/issues/256, https://github.com/ansible-collections/community.routeros/pull/257). diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py index 5518abd3..d2027d6d 100644 --- a/plugins/module_utils/_api_data.py +++ b/plugins/module_utils/_api_data.py @@ -4117,10 +4117,10 @@ def join_path(path): ), ('user', 'group'): APIData( unversioned=VersionedAPIData( - fixed_entries=True, primary_keys=('name', ), fully_understood=True, fields={ + 'comment': KeyInfo(can_disable=True, remove_value=''), 'name': KeyInfo(), 'policy': KeyInfo(), 'skin': KeyInfo(default='default'),