Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeos_config): Append save command into result #189

Merged
merged 3 commits into from
Nov 18, 2021
Merged

feat(edgeos_config): Append save command into result #189

merged 3 commits into from
Nov 18, 2021

Conversation

Turgon37
Copy link
Contributor

SUMMARY

Add "save" command into the "commands" array of the task results. Usefull when only a save is required and the task appear to be "changed: true" without any commands or diff (refer to #184 )

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

edgeos_config

ADDITIONAL INFORMATION

Before

TASK [Configure base settings] ************************************************************************************************************************************************************************************
changed: [net-rtr01-p01] => {"changed": true, "commands": []}

TASK [Configure firewall] *****************************************************************************************************************************************************************************************
ok: [net-rtr01-p01.dc01] => {"changed": false, "commands": []}

After

TASK [Configure base settings] ************************************************************************************************************************************************************************************
changed: [net-rtr01-p01] => {"changed": true, "commands": ["save"]}

TASK [Configure firewall] *****************************************************************************************************************************************************************************************
ok: [net-rtr01-p01] => {"changed": false, "commands": []}

@ansibullbot
Copy link
Collaborator

cc @Qalthos @samdoran
click here for bot help

@ansibullbot
Copy link
Collaborator

@Turgon37, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibullbot ansibullbot added affects_2 community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging labels Mar 30, 2021
virtualguy
virtualguy approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@virtualguy virtualguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed stale_ci CI is older than 7 days, rerun before merging labels Nov 10, 2021
@dericcrago
Copy link
Contributor

@Turgon37 - can you add a changelog fragment (https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to) please?

@virtualguy - thanks for the review!

@ansibullbot
Copy link
Collaborator

cc @jplitza
click here for bot help

@Turgon37
Copy link
Contributor Author

@Turgon37 - can you add a changelog fragment (https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to) please?

@virtualguy - thanks for the review!

Done :)

@Turgon37
Copy link
Contributor Author

Failed tests seem to not be related to my changes :)

@dericcrago dericcrago merged commit 15df9d9 into ansible-collections:main Nov 18, 2021
@dericcrago
Copy link
Contributor

thanks @Turgon37 & @virtualguy !

@patchback
Copy link

patchback bot commented Mar 8, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/15df9d9af0c9f3921c23a2f48e6bc9d4a8574fbb/pr-189

Backported as #375

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 8, 2022
@Turgon37 @patchback
feat(edgeos_config): Append save command into result (#189)
b294a0a 
* feat(edgeos_config): Append save command into result

* style(edgeos_config): Typo

* docs(): Add changelog fragment

Co-authored-by: Pierre GINDRAUD <[email protected]>
Co-authored-by: Pierre GINDRAUD <[email protected]>
(cherry picked from commit 15df9d9)
@patchback patchback bot mentioned this pull request Mar 8, 2022
Merged
Andersson007 pushed a commit that referenced this pull request Mar 8, 2022
@patchback @Turgon37
feat(edgeos_config): Append save command into result (#189) (#375)
5fa3a5a 
* feat(edgeos_config): Append save command into result

* style(edgeos_config): Typo

* docs(): Add changelog fragment

Co-authored-by: Pierre GINDRAUD <[email protected]>
Co-authored-by: Pierre GINDRAUD <[email protected]>
(cherry picked from commit 15df9d9)

Co-authored-by: Pierre GINDRAUD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virtualguy virtualguy virtualguy approved these changes

Assignees
No one assigned
Labels
affects_2 community_review feature This issue/PR relates to a feature request module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Turgon37 @ansibullbot @dericcrago @virtualguy @Andersson007